Repository navigation
feat: Apply server-side part picking in client mode - #210
Open
LKasianAnsys wants to merge 2 commits into
Open
LKasianAnsys wants to merge 2 commits into
LKasianAnsys wants to merge 2 commits into
Conversation
LKasianAnsys
force-pushed
the
feat/use-server-side-picking-in-client-mode
branch
from
November 5, 2026 15:33
75e3d34 to
911c746
Compare
LKasianAnsys
marked this pull request as ready for review
November 5, 2026 17:43
LKasianAnsys
force-pushed
the
feat/use-server-side-picking-in-client-mode
branch
from
November 5, 2026 18:14
911c746 to
d15a61b
Compare
LKasianAnsys
force-pushed
the
feat/use-server-side-picking-in-client-mode
branch
from
November 5, 2026 18:22
d15a61b to
4515cc7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #192
Summary
Client (WASM) mode now picks parts on the server instead of in the browser. This matches how geometry picking already works in client mode.
Backend
Added a
pick_part_in_viewtrigger onLocalApp. It takes a pixel, the window size and the client's camera, and returns the node id under that pixel, orNone. It doesn't change the selection.pick_part_in_viewtoVtkPipelineRenderer, which builds the pick view from the client's camera.VisorLocalScenecalls it under the scene lock, andVisorVTKLocalwires it intoLocalApp.PickInViewPayloadbase class.PickPartInViewPayloadandPickGeometryInViewPayloadnow extend it.Frontend
IRendererhas a newpickPartAsync(normX, normY). It replacesaddViewerClickedListenerwithaddCanvasClickListener, which reports a click's position and modifier keys but picks nothing.WasmRenderersendspick_part_in_viewto the server and parses the reply with a newPartPickReader. It no longer keeps its own actor-id to node-id map. The code that builds the pick view is now shared withpickGeometryAsync.VisorFrontend,VtkScene.js,ServerRendererandNullRendererare updated to the new click and pick flow.Tests