Skip to content

bound ApplicationXMLBuilder and DataSourceBuilder request bodies - #1334

Open
kali834x wants to merge 1 commit into
apache:masterfrom
kali834x:xml-datasource-builder-bounds
Open

kali834x wants to merge 1 commit into
apache:masterfrom
kali834x:xml-datasource-builder-bounds

Conversation

@kali834x

Copy link
Copy Markdown
Contributor

bound ApplicationXMLBuilder.processDocument and DataSourceBuilder.processDocument, the two stream-reading builders the 2.0.2 request-body ceilings missed, with the same SOAP_MAX_REQUEST_SIZE limit SOAPBuilder applies. application/xml is registered in the kernel, webapp and spring-boot-starter configs, so a plain pox body that text/xml bounds through SOAPBuilder was read unbounded by sending it as application/xml instead, and DataSourceBuilder copies the whole body into a byte[] via IOUtils.copy with no bound at all. the caller picks the builder by content-type, so leaving these two unbounded left soapMaxRequestSize avoidable, which is the reason the 2.0.2 note bounds every stream-reading builder and not only the form ones. -1 still opts out and bodies within the ceiling are unchanged; a RequestSizeLimitsTest regression drives each builder with an over-sized body and fails before the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant