Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bound ApplicationXMLBuilder.processDocument and DataSourceBuilder.processDocument, the two stream-reading builders the 2.0.2 request-body ceilings missed, with the same SOAP_MAX_REQUEST_SIZE limit SOAPBuilder applies. application/xml is registered in the kernel, webapp and spring-boot-starter configs, so a plain pox body that text/xml bounds through SOAPBuilder was read unbounded by sending it as application/xml instead, and DataSourceBuilder copies the whole body into a byte[] via IOUtils.copy with no bound at all. the caller picks the builder by content-type, so leaving these two unbounded left soapMaxRequestSize avoidable, which is the reason the 2.0.2 note bounds every stream-reading builder and not only the form ones. -1 still opts out and bodies within the ceiling are unchanged; a RequestSizeLimitsTest regression drives each builder with an over-sized body and fails before the change.