Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SourceBlockImpl, XMLStringBlockImpl and DataSourceBlockImpl now read their payload in _getReaderFromBO with StAXParserConfiguration.STANDALONE instead of the default StAXUtils configuration. the default leaves Woodstox resolving external entities and loading external DTDs, so when a Dispatch or Provider payload given as a StreamSource, String or DataSource carries ]>&e;, serializing the message inlines the file into the SOAP body that goes on the wire, and a DOCTYPE naming a SYSTEM DTD URL makes the reader open a connection to it (CWE-611). 3436bef hardened the identity transform for the same caller-supplied Source, but a StreamSource takes the direct StAX path in SourceBlockImpl and never reaches it, and the String and DataSource blocks do not transform at all. inbound messages are not affected, since those blocks are built from Axiom's SOAP parser, which already refuses a DOCTYPE; the exposure is an application that passes on XML it got from somewhere else, for example a gateway forwarding a client document through Dispatch or Dispatch. STANDALONE refuses the external entity and skips the external DTD while a DOCTYPE with only internal entities still parses, so the one behaviour change is that a payload which relied on an external entity or external DTD now fails to read. PayloadBlockExternalEntityTest points an entity at a temp file and fails for all three block types before the change, with an internal-entity control that passes both ways; jaxws (480 tests) and jaxws-integration (387, including the StreamSource, String and XML/HTTP DataSource dispatch and provider suites) pass.