Repository navigation
RAMPART-462: Use AlgorithmSuite encryption algorithm for symmetric key generation - #28
Conversation
|
Thanks, merged. Verified locally: the new test fails on master with a 16-byte key and passes with the fix, and the rest of the rampart-tests module is green. The change matches what AsymmetricBindingBuilder already does with the |
|
You're not calling it 2.0.2 to match Axis2? ;-)
Do you have a date in mind?
From: robertlazarski ***@***.***>
Date: Friday, 13 November 2026 at 12:32
To: apache/axis-axis2-java-rampart ***@***.***>
Cc: Andreas Martens ***@***.***>; Author ***@***.***>
Subject: [EXTERNAL] Re: [apache/axis-axis2-java-rampart] RAMPART-462: Use AlgorithmSuite encryption algorithm for symmetric key generation (PR #28)
This Message Is From an External Sender
This message came from outside your organization.
Report Suspicious<https://us-phishalarm-ewt.proofpoint.com/EWT/v1/AdhS1Rd-!9hFRWlwYOQXYH9xypocquIH5pqXYe8sBkLAqwbheKRFtVTUTtSYhko-uBVmPSBjhil5lIy15A4LXEUasWe_rFD3eOdJzp57y4wNp67TKkWW4xsjHefRX$>
[https://avatars.githubusercontent.com/u/58150512?s=20&v=4]robertlazarski left a comment (apache/axis-axis2-java-rampart#28)<#28 (comment)>
Thanks, merged. Verified locally: the new test fails on master with a 16-byte key and passes with the fix, and the rest of the rampart-tests module is green. The change matches what AsymmetricBindingBuilder already does with the
suite's encryption algorithm, so the two builders are now consistent. This will be in 2.0.0.
—
Reply to this email directly, view it on GitHub<#28?email_source=notifications&email_token=AEJLYB6ZOTDII6V2NXKMKND5YY6H3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMOBTHAZTCMJSGQ2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-6838311244>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEJLYB6Q7DNOA3LEL3LHFXD5YY6H3AVCNFSNUABFKJSXA33TNF2G64TZHMZDIOBWGQ2DQNZWHNEXG43VMU5TMMBTHEZDSMZTGY3KC5QC>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS<https://github.com/notifications/mobile/ios/AEJLYB67YWNSVLMWRM4KUAT5YY6H3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMOBTHAZTCMJSGQ2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android<https://github.com/notifications/mobile/android/AEJLYB5L5EI6PRBB7MDJJET5YY6H3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMOBTHAZTCMJSGQ2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today!
You are receiving this because you authored the thread.
Unless otherwise stated above:
IBM United Kingdom Limited
Registered in England and Wales with number 741598
Registered office: Building C, IBM Hursley Office, Hursley Park Road, Winchester, Hampshire SO21 2JN
|
|
@andreas-ibm if you become a committer, we could use your vote and do a release. FYI, I am working through this list of open issues below and just fixed RAMPART-421 . Most of these a quick fixes and in any event they will not hold up the release due to low impact. https://issues.apache.org/jira/projects/RAMPART/versions/12355237 |
|
Happy to be a committer, what do you need from me? |
|
@andreas-ibm see the page for the ICLA / CCLA agreement that the ASF requires: https://www.apache.org/licenses/contributor-agreements.html and more details at https://community.apache.org/contributors/becomingacommitter.html . If that is OK, the next step is that I still start a vote on the Axis private list that runs about a week and needs 3 votes to pass. To start a vote though, I need your full name and email address as it will appear on the ICLA / CCLA. If you prefer, you can send that info to robertlazarski@apache.org . |
SymmetricBindingBuilder.setupEncryptedKey()always generated an AES-128 session key(
KeyUtils.getKeyGenerator(WSConstants.AES_128)), regardless of the encryptionalgorithm in the policy's
sp:AlgorithmSuite.It now asks the policy's
AlgorithmSuitefor its encryption algorithm(
getEncryption()), and falls back to AES-128 if that is null.Fixes https://issues.apache.org/jira/browse/RAMPART-462
setupEncryptedKey()changes. Error handling isunchanged (the existing
printStackTrace()/return nullonWSSecurityExceptionis left as-is to keep this PR minimal).
Basic128) behaviour is identical.Basic256,Basic192,TripleDes) the generated key nowmatches the policy instead of being 128-bit AES.