Repository navigation
Conversation
Al-assad
marked this pull request as ready for review
November 4, 2026 07:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StatefulSet comparison trusted stored desired-state hashes, hiding live image/replica drift and omitting update strategy. Its legacy environment compatibility path could dereference nil replicas. CN template updates could reset HPA-scaled replicas to the initial CR count.
Compare normalized live managed StatefulSet fields, including API-defaulted Pod/container/probe/volume values. Preserve harmless legacy CONFIGMAP_MOUNT_PATH duplicates using actual field comparison. Render the BE init-image fallback before comparison. Patch from the current object with optimistic locking and retain external template metadata. While CN HPA is configured, use CR replicas for creation only and preserve actual replicas on subsequent template updates.
Validation:
go test ./...passed with Kubernetes 1.31 envtest.QA validation passed on isolated DCR/DDC workloads.
rc07verified upgrade without Pod/template/PVC changes, native BE and DDC MS replica correction, strategy repair, and HPA template updates retaining 2 actual replicas for both explicit and omitted initial counts. Final combinedselectdb/doris-operator:26.1.0-rc10also passed event-driven drift correction with no CR mutation and retained sentinel data (3 rows, sum 6).Additional regressions ensure the legacy exception never suppresses newly added configuration environment variables, and unsupported immutable StatefulSet changes are still rejected by the API. The final combined source passed full Go tests, vet, and targeted race checks; both image architectures passed startup smoke tests. Existing immutable PVC handling and CG graceful/decommission workflows remain responsible for their fields. Ownership protection is submitted separately in #542 and should land before broad drift reconciliation.