Repository navigation
Conversation
…elay_seconds Closes apache#535 The operator sets the BE pod's terminationGracePeriodSeconds to exactly grace_shutdown_wait_seconds from be.conf. But the BE's graceful stop takes up to grace_shutdown_wait_seconds + grace_shutdown_post_delay_seconds. grace_shutdown_post_delay_seconds defaults to 30s, which ensures fragments of the same query on other BEs can finish before this BE disappears. Previously the operator only read grace_shutdown_wait_seconds, so the gap exactly remained grace_shutdown_post_delay_seconds. Now the operator reads both values and returns their sum, so the termination grace period covers the BE's whole graceful stop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #535
Summary
Fixes Apache Doris Operator issue #535 where the BE pod's
terminationGracePeriodSecondswas set to onlygrace_shutdown_wait_seconds, ignoringgrace_shutdown_post_delay_seconds(default 30s). This causes kubelet to SIGKILL the BE process during the post-stop delay period.Changes
GRACE_SHUTDOWN_POST_DELAY_SECONDSconfig key constantDefaultPostDelaySecondsvariable (default 30s from Apache Doris)GetTerminationGracePeriodSeconds()to returnwaitSeconds + DefaultPostDelaySecondsBehavior Change
wait=120onlypost_delay=60explicitwait + 60How It Works
The operator now reads both
grace_shutdown_wait_secondsandgrace_shutdown_post_delay_secondsfrom be.conf and returns their sum asterminationGracePeriodSeconds, ensuring the Kubernetes pod has enough grace period for the full BE graceful shutdown process.