Repository navigation
Conversation
deniskuzZ
marked this pull request as draft
October 1, 2026 18:27
Contributor
|
LGTM +1, pending tests Before Patch, Tested the query on local setup and after its working ✅ |
- Both DataWritableReadSupport helpers fell back to the whole file schema when no column was projected: the HIVE-10975 workaround for Parquet 1.8.0 rejecting an empty schema, copied by HIVE-17696; PARQUET-363 (1.8.2, 1.9.0) allows it - Request no column instead: count(*) and partition-only reads stop reading columns they never decode; on LLAP count(*) takes the native path (parquet_llap_counters.q: HDFS_BYTES_READ 18,616 -> 0) - Fixes the vectorized read of only row lineage columns: they were appended to the whole schema but paired with colsToInclude by position (IndexOutOfBoundsException)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changes were proposed in this pull request?
DataWritableReadSupporthelpers (vectorizedgetRequestedSchema,init)Why are the changes needed?
count(*)and partition-only reads read every column of the file and decode none of them. On LLAP the empty projection carried the table's nested columns, socount(*)declined the native path to the fallback reader (parquet_llap_counters.q: HDFS_BYTES_READ 18,616 -> 0, ROWS_EMITTED 2098)IndexOutOfBoundsException: Index 2 out of bounds for length 2inParquetRowGroupDecoder.buildColumnReaders. The lineage columns were appended to the whole file schema but to an emptycolsToInclude, and the two are paired by positionDoes this PR introduce any user-facing change?
No
How was this patch tested?
count(*)with no projected column on the LLAP native pathSELECT part, COUNT(0) ... GROUP BY part, vectorization off) now reads with an empty schema