Repository navigation
[core] Fix rollback_to_watermark with repeated snapshot watermarks - #11149
Open
chenjian2664 wants to merge 1 commit into
Open
chenjian2664 wants to merge 1 commit into
chenjian2664 wants to merge 1 commit into
Conversation
chenjian2664
marked this pull request as ready for review
November 15, 2026 00:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When several snapshots share a watermark,
rollback_to_watermarkcould roll back to a snapshot in the middle of that run and drop later snapshots that also carry the requested watermark. Repeated watermarks are common because the commit watermark takes the maximum, so compaction snapshots and commits without their own watermark inherit the previous one.earlierOrEqualWatermarknow keeps searching to the right on an exact match and returns the last such snapshot, mirroring the lower-bound handling oflaterOrEqualWatermarkfrom #10420.Tests