Repository navigation
Support BuildKit build secrets - #854
Merged
Merged
Conversation
Replace the implementation proposed in #821 with session-based secret delivery that preserves caller options, handles optional missing secrets, and retains session health checks. Add RPC and Docker integration coverage for callback and promise builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BuildKit builds can now receive a
secretsmap of IDs to Buffers through the session's Secrets/GetSecret RPC. This replaces #821 while preserving the session health service added in #847.The build request copies the caller's options before excluding secrets from the URL, so the provider retains the values and callers can reuse their options. Missing or inherited IDs return NOT_FOUND, allowing optional secret mounts to work; invalid values and secrets larger than 500 KiB return INVALID_ARGUMENT.
Validation: 29 targeted tests passed locally on Node 24 against Docker Engine 29.9.2. Coverage includes binary and empty secrets, missing and invalid values, session health and registry authentication, callback and Promise builds, secret exclusion from request options and logs, and secret mount removal after the build step. Existing BuildKit, regular build, progress, and utility checks also passed.