Repository navigation
Start under another release name; withdraw 0.5.7 (APT-1102) - #34
Merged
Merged
Conversation
…t only (APT-1102) At every startup the server registers its prompt version and refused to become ready unless the stored row's release revision matched the running release. The Platform changes an app's version in two steps (the new version's configuration on the old image, then the new image), so a 0.5.7 binary started under any other version name never became ready and the version could be neither raised nor lowered. The release revision is now provenance of the first registration: stored on insert, never compared, never updated. Different template or schema content under the same id still conflicts.
An installation of 0.5.7 cannot change version, so nothing should install or move to it. The publisher marks versions listed under the publisher-only withdrawnVersions key as served: false and refuses to publish them.
Contributor
Author
|
Merging on the PO lead's decision (森さん's instruction of 2026-11-15 to ship 0.5.8): independent review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
朝の 5 行(森さん向け)
served: false。0.5.7 の再発行を断る)。ただし、いまは環境まで届かない: カタログを出す側(Cloud)と、Platform のカタログの取り込みが、どちらも全部の版をserved: trueに書き直す(APT-1105)。環境に届く効果は「既定が新しい版に移る」だけ。0.5.7 は、手で選べば、まだ入る。8eccf4c。Go の変更に指摘なし。取り下げが下流で効かない = 上の 1(b)、APT-1105)。そのあとの commit は、README とコメントの文言だけ。確かめていないこと: Platform の入れ替えの動きそのもの(AppInstallation → transition → Knative)。下の smoke は、実行ファイル・版の名前・DB の組み合わせだけを確かめる。カタログを出す側(appthrust/cloud)がserved: falseをそのまま通すかは、未確認。What (APT-1102, urgent; part of APT-1096)
Prompt registration now identifies a prompt version solely by its schema version, template hash and schema hash. The release revision remains immutable provenance of its first registration rather than a startup compatibility requirement, allowing identical prompt content to survive upgrades, downgrades and the Platform's config-first/image-second rollout. Real PostgreSQL regressions cover existing and initially empty registrations, repeated restarts in both directions, provenance preservation, and continued rejection of content mismatches.
The publisher gains a publisher-only
withdrawnVersionskey incatalog/entry.yaml: a listed version is submitted withserved: falseand cannot be published again.0.5.7is listed. The flag does not reach estates today - Cloud (apps/api/src/catalog-contract.ts) and the Platform (app_catalog_source_artifact.go) both writeserved: truefor every version (APT-1105) - so the effective change is that the default moves to the new release.Why
Observed on ink (2026-11-15): changing an installed 0.5.7 to another version never became ready. The Platform changes an app's version in two steps - the new version's configuration on the old image, then the new image. In step 1 the 0.5.7 binary started under the other version name;
RegisterBuildPromptVersioncomparedrelease_revision(fromBUILDER_CONSOLE_RELEASE_VERSION) with the stored row and refused:conflict: Prompt version is already registered with different content, every 30 s, never ready; step 2 never ran. The same happens for an upgrade from 0.5.7. Users were not affected (the previous revision kept serving), but the version could be neither raised nor lowered, and the stuck change took about 20 minutes to fail.Smoke: real images, one real PostgreSQL, in the Platform's order
Each row starts the named image with the named
BUILDER_CONSOLE_RELEASE_VERSIONagainst the same database as the rows above it in its group and reads/readyz.localis this branch's server binary on top of the 0.5.7 image (the SPA is irrelevant to startup). Containers and the database were removed afterwards.Reproduction of the defect with published images
This branch
release_revisionstays the first registration's (0.5.8).Limits: this does not exercise the Platform's rollout (AppInstallation → ContainerInstanceTransition → Knative), routing, or real configuration; the local binary was built with the host Go toolchain, not the Dockerfile's.
Not changed
-updatecan rewrite the goldens under the same id) - follow-up.Checks (on the committed tree, head
8eccf4cfor Go; docs-only commit after)go vet ./cmd/server/...,go test ./cmd/server/... -count=1against PostgreSQL 17 (BUILDER_CONSOLE_TEST_DATABASE_URL, UTC),bun test hack. Not run: web checks (no web change), image build through the Dockerfile.