Repository navigation
One unreadable row, plan or admin-only read no longer blanks the Console (APT-1109, APT-1114) - #36
Merged
Merged
Conversation
…(APT-1109) The stack list reader required templateId to be a DNS label. Platform sends "" for stacks installed from the catalog (the Builder Console itself, built-in apps), so one such row made the whole list a contract violation and every page that reads app status showed "アプリの状態を確認できませんでした". Every Project has at least one such stack.
…PT-1109) The create flow reads the same stack list through a second reader, which still rejected a catalog-installed stack: the name check never ran and the readback after an unconfirmed create threw. Both readers now use one schema. The overview shows a missing template as none instead of a blank.
A stored creation plan is written by the AI and accepted by the Platform under rules that are looser than the request schema the console read it with, so one draft whose plan said publish.enabled:false failed the draft list and, with it, app status for the whole Project. Readers of the draft list and of both stack lists now read each row on its own: a row a reader rejects becomes an explicit unreadable entry (its id only). A draft whose stored plan or approval cannot be read still decodes, with the plan or approval marked unreadable; nothing is validated, executed, retried or written from it, and only re-planning is offered. A disabled publish block is read as absent. Publishes may carry empty application, branch and component ids and are then attributed to no app.
…APT-1114) The create page read source connections, the cluster-level registry connections and the Project's domains as one query. For anyone who is not a Platform Admin the registry read answers 403, the whole query failed, and every entry reported a missing publish domain. A 403 on the registry read alone is now an empty list; any other failure, and a 403 on any other read, still fails as before.
Review of the tolerant readers found that stopping at an unreadable approval snapshot left the Platform to run the execution on its own, producing an app the Console never bound. The snapshot is the Platform's copy: an existing execution is now followed by its id and status whether or not the snapshot or the stored plan can be read, and only a new creation needs a readable plan. The snapshot's summary and tool plan take the plan's bounds, which is what the Platform writes. Also: name availability is unchecked while any stack row is unreadable; an improvement with an unreadable plan offers a new improvement instead of a generation the Platform refuses; rejected rows report their schema paths; an app whose creating draft is unreadable is not presented as finished.
…lete (APT-1109) Re-review found that the view for such an app carried no stack, so deleting it removed only the Console record and orphaned the running stack. The normal view is now derived first and only its build status becomes unknown; edit, delete, discard, sharing and rollback are not offered for either unreadable marker. An unreadable draft row no longer blocks a new AI creation or improvement for the whole Project: it is never resumed, written or deleted, and new work starts beside it. A reply is not cleared, and no retry is offered, where an unreadable plan means nothing would be sent.
Contributor
Author
|
マージの根拠(bugfixer): PO リードの決定(2026-11-15、APT-1096 / APT-1109 / APT-1114。「差分の再レビューが『マージしてよい』で、Craftsman の実物が全部通れば、マージ・発行に進んでよい」)。独立レビュー 5 回、最後(head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
朝の 5 行(森さん向け)
82d8859): 検査の層「マージしてよい。後続つき」、使う側の層「変更が要る」(承認の控えが読めないと、始めた作成が置き去りになる、ほか)→ 直した(20b9222)。差分の再レビュー「変更が要る」(印を付けたアプリの削除が、動いている一式を取り残す、1 件)→ 直した(da91413)。差分の再レビュー 2(da91413)「マージしてよい。後続つき」、必ず直す点 0 件(後続は APT-1117)。 全文はpo/lead-2026-11-14/reviews/builder-console-36-review.md。実物で確かめたこと: (a) Craftsman の実際の応答(rc.34、アプリ 18・一式 18・公開 17・下書き 3 + 詳細 3 件・ソースのリポジトリ 8)= 候補の検査に全部通る。読めない扱いに落ちる行は 0。(b) ink の検証用の Project の実物の応答(GET 216 本)を再生して、候補の Web で 6 画面を開いた = あの文言なし。(c) 実物の応答を 1 か所だけ壊して、「読めない」の画面を開いた。{"version":"0.5.8"})。Web だけの変更で、サーバーと DB は 0.5.8 と同じ。What (APT-1109, APT-1114; part of APT-1096)
Console 0.5.7 / 0.5.8 read every Platform response through a strict reader, and a single rejected value failed the whole query. Three real shapes did that in every Project:
templateId: ""on stacks installed from the catalog failed the stack list (both readers of it);publish: {enabled: false}failed the draft, and with it the draft list for everyone in the Project;GET /api/v1/registry-connectionsanswers 403, which failed the create page's combined connections read and made every entry report a missing publish domain (present since 0.5.6).Change
api/boundary/rows.ts) for the draft list and both stack-list readers. A rejected row becomes an unreadable entry that keeps only a DNS-label id; its rejected schema paths are reported (no values, no ids; deduplicated, capped).contracts/platform/stored-plan.ts): one the canonical schema rejects becomes a marker and its content is discarded; the draft and its executions stay readable. A disabled publish block reads as no publish. The snapshot takes the plan's bounds forsummaryandtoolPlan(the Platform copies the plan into it; APT-1115).api/queries/catalog.ts): a 403 on that read alone is an empty list. 401, 5xx, network failures, contract violations, and a 403 on any other read fail as before.cmd/.Known limits (APT-1117)
Verification
da91413:bun run typecheck,typecheck:e2e,bun test src(2,031 pass),check:response-boundaries(0 violations),check:console-schema.git diff --stat v0.5.8 HEAD -- cmd go.mod go.sum Dockerfile catalog hack .githubis empty apart from Show a rejected plan as a plan to fix, not a platform fault (APT-1094) #35's web changes: the server is the 0.5.8 server.