Skip to content

A running app keeps its status when a build is recorded as failed; the build page says when the AI work is done (APT-1136, APT-1124) - #37

Merged
reoring merged 3 commits into
mainfrom
fix/app-running-build-failed-and-built-heading
Nov 16, 2026
Merged

reoring merged 3 commits into
mainfrom
fix/app-running-build-failed-and-built-heading

Conversation

@reoring

@reoring reoring commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

朝の 5 行(森さん向け)

  1. 何が変わるか: (1) 動いているアプリは、最新のビルドが「失敗」と記録されていても、状態を「ビルドに失敗しています」に書き換えない。(2) AI の実装が終わったら、作成の画面の見出しを「できました」に変え、「公開する」を次の操作として出す。実装の最中は「作業 3 / 4」と経過時間を出す。
  2. 届いたときに見える変化・止まるもの: 正常に動いているのに「ビルドに失敗しています」「問題あり」と出ていたアプリが「公開中」に戻る(アプリの画面に黄色の注意書きは出る)。AI の作成の画面が「作っています」のまま止まって見えることが無くなる。止まるものは無い。
  3. 決めてほしい点と推奨: なし(森さんの決定 2026-11-16: 動いている版が在れば、ビルドの失敗でも「公開する」を押せる + 押す画面に注意書き。初回の失敗は止める)。
  4. 独立レビュー: 2 回(同じ読み手)。1 回目(e679f85)「マージしてよい。後続つき」— 文面・作成の画面・「動いている」の判定の 3 点を、発行の前に閉じた。2 回目(4ad5b76)「マージしてよい。後続つき」、必ず直す点 0 件。全文は po/lead-2026-11-14/reviews/builder-console-0510-review.md。実物で確かめたこと: Craftsman の実際の応答(ビルドが「失敗」と記録された、動いているアプリの行を含む)を、発行済みの 0.5.9 と候補で開いた = 0.5.9 は「ビルドに失敗しています」+「問題あり 1」、候補は「公開中」+ 注意書き +「問題あり」なし。
  5. 戻し方: Console を 0.5.9 に戻す(PATCH {"version":"0.5.9"})。Web だけの変更で、サーバーと DB は 0.5.9 と同じ。

What (APT-1136 Console side, APT-1124)

APT-1136. The Platform recorded a healthy app's source build as failed because it observed an unrelated failed GitHub Actions run (fixed in platform #6932, which reaches environments with the next release). The Console replaced the app's status everywhere with 「ビルドに失敗しています」 and counted it under 「問題あり」; on the build page it also disabled 公開する.

APT-1124. After creation the build page stayed on 「作っています」 until the user published, whether the AI was working, had finished, had changed nothing, or had stopped.

Change (web/ only)

  • Running release (model/app.ts hasRunningRelease): the web component is Ready and its latest release is not known to have failed. For such an app a failed source build no longer overrides the status in the header, lists, counts, the overview and the build page. It is shown as a warning (「最新のビルドが失敗と記録されています」 - the app keeps running; recent changes may not be in it yet) on the app page, above 公開する on the build page and in the publish step, and as a row under 詳しい人向け. An app with no running release is shown and blocked exactly as before; an unknown status stays unknown.
  • Build outcome (model/build/stage.ts buildOutcome, both engines): implementing → task progress and elapsed time; done with pushed work → 「できました」, the stepper moves to 公開, a line saying what 公開する does and a primary 公開する; all tasks skipped → 「変更がありません」; failed or cancelled → 「止まっています」; lease lapsed → 「再開を待っています」.
  • No request is added, removed or re-timed. 「AI に直させる」 appears only where 0.5.9 already offered it.

Known limits (next version)

  • A real failure of the AI's pushed code, with the template still serving, reads 「できました」 with 公開する enabled and only the warning (accepted; a firmer line when the implemented release is not live is possible without new data).
  • A running app whose status is unknown gets an enabled 公開する without the warning.
  • The legacy build page's red build-failure notice (when the server extracted a cause) is unchanged and sits above the new wording.
  • While read models load, the failure card can flash for a moment.

Verification

  • On the committed tree 4ad5b76: bun run typecheck, typecheck:e2e, bun test src (2,060 pass), check:response-boundaries (0 violations), check:console-schema.
  • Built bundle on the published 0.5.9 server with real Craftsman responses (component summaries were not available there and were re-keyed from a real Ready summary of another environment; Console's own API was the repo mock; writes blocked): list and app page as in point 4.
  • Not verified here: a logged-in session on a live Console; the build page with live data (done on appthrust.ink after publishing).
  • git diff --stat v0.5.9 HEAD -- cmd go.mod go.sum Dockerfile hack catalog .github is empty.

… page says when the AI work is done (APT-1136, APT-1124)

A failed source build replaced the status of the app everywhere, even when a
release was serving: the header, every list and the problem count said the
build had failed. For an app with a running release the status is now the
app's own; the failed build is a warning on the app page and a row under the
details, and is not counted as a problem. An app that has never run, or whose
AI build is still in progress, is shown as before.

After creation the build page stayed on 作っています until the user published,
whether the AI was working, had finished, had changed nothing, or had stopped.
It now shows task progress and elapsed time while working, できました with
公開する as the next action when done, and its own wording when the run
changed nothing, failed, or is waiting to resume.
…nly what is known (APT-1136, APT-1124)

Review of the previous commit:

- The build page read the source build state directly, so a failed build on an
  app that was serving still disabled 公開する, pulled a published draft back
  to 作る and hid the new progress and finished states. It now follows the
  same rule as the app view; the warning is shown above 公開する and in the
  publish step. An app with no running release is blocked as before.
- Running means the web component is Ready and its latest release is not
  known to have failed, so an unloaded or failed release overview no longer
  flashes a build failure.
- The notice no longer says recent changes are missing: the Console cannot
  tell a real failure from one recorded against an unrelated run.
- The unchanged-outcome retry is not offered after an unconfirmed write; the
  console-v1 line points at saving the audience first.
@reoring reoring added the needs-human-review Waits for a person's review before merge label Nov 16, 2026
The build page now shows the publish action in the header and in the
conversation once the AI work is done, and a retry in the panel and in the
conversation when the run changed nothing. The stories scope each locator to
its landmark and assert that the conversation's action is available together
with the header's.
@reoring

reoring commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

マージの根拠(bugfixer): PO リードの指示(2026-11-16「進めてよい(マージ → 発行 → ink)」)と森さんの決定(動いている版が在れば、ビルドの失敗でも「公開する」を押せる + 押す画面に注意書き。初回の失敗は止める)。独立レビュー 2 回、最後(4ad5b76)は「マージしてよい。後続つき」、必ず直す点 0 件。4ad5b76 → d3f0762 の差分は通しのテストの 3 file だけ(web/src は不変)。head d3f07623d22e281e504005d0c6bb41632bd6986c で CI 6 つ成功(console-mock-stories を含む)。Craftsman の実物の応答での確認は PR の説明のとおり。

@reoring reoring removed the needs-human-review Waits for a person's review before merge label Nov 16, 2026
@reoring
reoring merged commit 695ae31 into main Nov 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant