Repository navigation
A running app keeps its status when a build is recorded as failed; the build page says when the AI work is done (APT-1136, APT-1124) - #37
Merged
Conversation
… page says when the AI work is done (APT-1136, APT-1124) A failed source build replaced the status of the app everywhere, even when a release was serving: the header, every list and the problem count said the build had failed. For an app with a running release the status is now the app's own; the failed build is a warning on the app page and a row under the details, and is not counted as a problem. An app that has never run, or whose AI build is still in progress, is shown as before. After creation the build page stayed on 作っています until the user published, whether the AI was working, had finished, had changed nothing, or had stopped. It now shows task progress and elapsed time while working, できました with 公開する as the next action when done, and its own wording when the run changed nothing, failed, or is waiting to resume.
…nly what is known (APT-1136, APT-1124) Review of the previous commit: - The build page read the source build state directly, so a failed build on an app that was serving still disabled 公開する, pulled a published draft back to 作る and hid the new progress and finished states. It now follows the same rule as the app view; the warning is shown above 公開する and in the publish step. An app with no running release is blocked as before. - Running means the web component is Ready and its latest release is not known to have failed, so an unloaded or failed release overview no longer flashes a build failure. - The notice no longer says recent changes are missing: the Console cannot tell a real failure from one recorded against an unrelated run. - The unchanged-outcome retry is not offered after an unconfirmed write; the console-v1 line points at saving the audience first.
The build page now shows the publish action in the header and in the conversation once the AI work is done, and a retry in the panel and in the conversation when the run changed nothing. The stories scope each locator to its landmark and assert that the conversation's action is available together with the header's.
Contributor
Author
|
マージの根拠(bugfixer): PO リードの指示(2026-11-16「進めてよい(マージ → 発行 → ink)」)と森さんの決定(動いている版が在れば、ビルドの失敗でも「公開する」を押せる + 押す画面に注意書き。初回の失敗は止める)。独立レビュー 2 回、最後( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
朝の 5 行(森さん向け)
e679f85)「マージしてよい。後続つき」— 文面・作成の画面・「動いている」の判定の 3 点を、発行の前に閉じた。2 回目(4ad5b76)「マージしてよい。後続つき」、必ず直す点 0 件。全文はpo/lead-2026-11-14/reviews/builder-console-0510-review.md。実物で確かめたこと: Craftsman の実際の応答(ビルドが「失敗」と記録された、動いているアプリの行を含む)を、発行済みの 0.5.9 と候補で開いた = 0.5.9 は「ビルドに失敗しています」+「問題あり 1」、候補は「公開中」+ 注意書き +「問題あり」なし。{"version":"0.5.9"})。Web だけの変更で、サーバーと DB は 0.5.9 と同じ。What (APT-1136 Console side, APT-1124)
APT-1136. The Platform recorded a healthy app's source build as
failedbecause it observed an unrelated failed GitHub Actions run (fixed in platform #6932, which reaches environments with the next release). The Console replaced the app's status everywhere with 「ビルドに失敗しています」 and counted it under 「問題あり」; on the build page it also disabled 公開する.APT-1124. After creation the build page stayed on 「作っています」 until the user published, whether the AI was working, had finished, had changed nothing, or had stopped.
Change (
web/only)model/app.tshasRunningRelease): the web component is Ready and its latest release is not known to have failed. For such an app a failed source build no longer overrides the status in the header, lists, counts, the overview and the build page. It is shown as a warning (「最新のビルドが失敗と記録されています」 - the app keeps running; recent changes may not be in it yet) on the app page, above 公開する on the build page and in the publish step, and as a row under 詳しい人向け. An app with no running release is shown and blocked exactly as before; an unknown status stays unknown.model/build/stage.tsbuildOutcome, both engines): implementing → task progress and elapsed time; done with pushed work → 「できました」, the stepper moves to 公開, a line saying what 公開する does and a primary 公開する; all tasks skipped → 「変更がありません」; failed or cancelled → 「止まっています」; lease lapsed → 「再開を待っています」.Known limits (next version)
Verification
4ad5b76:bun run typecheck,typecheck:e2e,bun test src(2,060 pass),check:response-boundaries(0 violations),check:console-schema.git diff --stat v0.5.9 HEAD -- cmd go.mod go.sum Dockerfile hack catalog .githubis empty.