Repository navigation
endpoint: a failed observation retains generated records; record withdrawal transitions (APT-866) - #27
Merged
Conversation
…drawal transitions (APT-866)
Contributor
Author
|
Owner review: approved by reoring in the supervising session (2026-11-13, "ほかのreview は ok"). Merging on that approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A failed read or conversion no longer becomes "nothing desired" followed by pruning, and every withdrawal transition is recorded (platform ADR-0083 revision 6, rules R5 and R6; tracker APT-866).
Error is not rejection (endpoint-recordset controller)
Each hostname now resolves to one of three typed outcomes:
InvalidInput/UnsupportedTarget(non-retryable), invalid generated name, observed Zone policy denialEndpointProviderCapabilityA genuine failure (List/Get error, conversion transport error including 401/403, malformed response, UID mismatch, retryable or unknown conversion failure, missing REST config) aborts the pass, retains every child, and reports
Resolved=Unknown/Ready=Unknownwhile keepingAccepted,Programmedand the previous child snapshot.Before:
convertEndpointRecordSetreturned(nil, message, nil)for API errors,recordSetsForHostnametreated that as a rejected candidate, andapplyRecordSetsdeleted the existing children. One transient API error could withdraw the records of a serving name.Shared helpers return what happened
declaration.RecordSetAllowedByZoneandWithdrawalAllowedByZonereturn the Namespace read error instead offalse. Callers migrated: endpoint controller, core ZoneUnit composition, core withdrawal composition. A read error now retains instead of composingNotAllowed.retirement.RetireOrDeletereturns a typed outcome (Patched,Deleted,NoChange) with its error. Callers migrated: gateway-endpoint and service-endpoint controllers.Transition records
One log line and one Event, on the successful transition only:
HostnameRemoved,EndpointRecordSetRetired,EndpointRecordSetDeleted,RecordSetPruned. Failed writes, NotFound and repeated reconciles of a terminating object emit nothing. The manager ClusterRole already grantseventscreate/patch.Not changed
Provider controllers; the D4 retention rule from #26. Route 53 has a private
namespaceAllowedthat still hides Get errors, but it has no production caller.Behaviour change to review
A hostname whose Zone match or capability disappears keeps its generated
RecordSets until the hostname is removed from theEndpointRecordSet, the set is retired, or the hostname is explicitly rejected. Previously they were pruned.Checks
go test ./... -count=1: 38 packages ok.deploy/charts/dns-apiTestExternalKustomizeParityfails on this workstation with and without the change becausekustomizeis not installed; left to CI.go vet ./internal/go/...: cleangit diff --check: clean