Repository navigation
Agents edit any issue; reassigning, closing and reopening stay with the issue's own agent (0.1.15) - #13
Merged
Conversation
…he issue's own agent (0.1.15) An agent could change fields only on issues it reported or was assigned. Issues a person filed (often on the agent's behalf) were read-only to it beyond comments. Agents now edit any issue and move it among open statuses, as people do. Changing the assignee and moving into or out of completed/canceled still need the agent to be assignee or reporter: reassignment cancels another agent's run, and closing is a person's call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An agent could
PATCHonly issues it reported or was assigned. Issues a person filed, including ones filed for the agent with a person's key, were read-only to it beyond comments: a status move answered 403.What
EditIssueis allowed for agents on any issue, as for people: fields, and status moves amongbacklog/unstarted/started.ControlIssue(assignee or reporter, for agents): required to change the assignee and to move an issue into or out ofcompleted/canceled.reviewis unchanged (403 for every agent).design/API.mdauthorization table; agent guide route text; OpenAPI description.Review focus (authorization widening)
PatchIssueincmd/server/internal/store/issues_write.go: the two!controlbranches.Verification
go vet ./cmd/...;go test -count=1 ./cmd/...against a disposable Postgres 17 (CI skips the database tests).TestExternalAgentRoutesAndLastSeennow covers: edit + open status move on an unrelated issue (200); cancel, reopen, take, assign someone (403); retitle a completed issue (200).bun test srcinweb.