Repository navigation
Conversation
This was referenced Nov 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose Commons 10 canonical address models through the v2 HTTP API and public
/v2/streamWebSocket endpoint, with shared query owners for both transports.POST /v2/accountslookup and one-second blank-line heartbeats on v2 NDJSON streams. Legacy streams remain heartbeat-free. Transaction publication stays on HTTP atPOST /v2/transactionswith its existing confirmation deadline.HandshakeProtocol, preserving one-time consumption and transport-owned admission/deadlines. Consolidate each election voter's candidate, latest timestamp, and stability timestamp into one immutable state. Move query tests with their owners and update the runtime maps.10.0.0-SNAPSHOTand Spring Boot to 4.1.2.Validation passed on the exact signed PR snapshot with Java 25: all 515 tests, full
ktlintCheck, andbootJar. Coverage includes query handoff/cancellation, HTTP/OpenAPI and legacy compatibility, mutable WebSocket streams, handshake behavior, and voter-state transitions. After the shared server cancellation fix, all 20 targeted stream/HTTP boundary checks, fullktlintCheck, andbootJarpassed against the fixed module. The rebuilt Node JAR and pinned integration image contain that exact reviewed server artifact; application sources are unchanged. The released-live neighbour suite was not rerun; legacy HTTP compatibility is covered by real socket tests using frozen released payloads.This change depends on publication of the matching Commons 10 artifacts; the current development snapshot is not published remotely. Upgrade remote signers before enabling these canonical Node requests, then deploy this Node before Gatekeeper or clients requiring its v2 APIs. Wallet-server migration and production rollout remain separate work.
Independent Astra Max review covered the complete 122-path PR diff with no actionable findings. An additional packaged-decoder probe passed 82 canonical and legacy input cases.
Related PRs: Commons, Gatekeeper, Signer.