Repository navigation
Conversation
checkout, setup-go, cache and upload-artifact move from their May 2025 commits to the current releases (v7.0.1, v7.0.0, v6.1.0, v7.0.2). mysql/example_test.go shows the MySQL API: Setup, a custom initializer, a template in TestMain, keep-on-failure. The examples are compile-checked rather than run, since a runnable example cannot skip when no MySQL server is reachable, and this module's MySQL tests skip rather than fail on a machine that only runs PostgreSQL.
The pool records a prepared database before cloning into it, so two records can exist while the second CREATE DATABASE has not run yet; CI killed the holder at that instant and found one database. The test now waits for both databases to exist, which also makes a kill mid-clone a case the sweep is seen to handle.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small things.
checkout,setup-go,cacheandupload-artifactactions move from their May 2025 commits to the current releases (v7.0.1, v7.0.0, v6.1.0, v7.0.2), pinned by SHA as before.golangci-lint-actionwas already current.mysql/example_test.goshows the MySQL API on pkg.go.dev:Setup, a custom initializer, a template inTestMain, keep-on-failure. They are compile-checked rather than run: a runnable example cannot skip when no MySQL server is reachable, and the module's MySQL tests skip rather than fail on a Postgres-only machine, so running examples would break that.