Repository navigation
Conversation
Nothing in testdb needs Go 1.27; the newest features in use are WaitGroup.Go (1.25) and b.Loop and t.Context (1.24). Every module's go directive is now 1.26.0, so testdb builds on 1.26 and later, and CI tests on both 1.26 and 1.27.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing in testdb needs Go 1.27: the newest language or library features in use are
WaitGroup.Go(1.25) andb.Loop/t.Context(1.24). The 1.27 requirement came from the toolchain bump, not from any feature, and it shuts out projects that are on 1.26.Every module's
godirective is now1.26.0, so testdb builds and runs on Go 1.26 and later. CI tests on both 1.26 and 1.27 so a newer-only feature cannot slip in unnoticed. Verified locally with the Go 1.26.5 toolchain: build, vet, lint and the full suite across all eight packages against Postgres and MySQL.