Repository navigation
lutabsorb: make -K disable the LUT library - #608
Open
flyingfoxyy wants to merge 1 commit into
Open
flyingfoxyy wants to merge 1 commit into
flyingfoxyy wants to merge 1 commit into
Conversation
An explicit -K now takes precedence over the LUT library, matching the behavior of the if command. Without a library no area gain is printed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lutabsorblet the installed LUT library override an explicit-K: the default LUT size was computed asmin(6, LutMax), and when-KexceededLutMaxit was truncated toLutMaxwith only a warning. Since ABC installs a built-in 4-input LUT library at startup (If_Init),lutabsorb -K 6actually ran with K=4 and skipped every candidate node with more than 4 fanins.This makes
-Kbehave the same way as in theifcommand: when-Kis given, the LUT library is disabled and the requested LUT size is honored exactly. When-Kis not given, the library is still used for the default LUT size and the area check. Without a library there is no area model, so the verbose per-round line and the final summary no longer print an area gain.Test
Without
-K, the default library is still used (K = 4 with the built-in library). With-K 6the size is honored:With a library (built-in or read with
read_lut), the area gain is still reported:test/issues/issue70.shpasses.