Repository navigation
BRE2-1286: Validate SSH certificate authority entries - #528
Draft
stephahart wants to merge 1 commit into
Draft
stephahart wants to merge 1 commit into
stephahart wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
==========================================
+ Coverage 33.51% 38.01% +4.50%
==========================================
Files 153 136 -17
Lines 21654 20118 -1536
==========================================
+ Hits 7257 7648 +391
+ Misses 13624 11675 -1949
- Partials 773 795 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate the CA public key and node/user principal components before writing authorized_keys. Reject extra keys, key options, control characters, and principal patterns; serialize the parsed public key so server comments cannot inject entries.
Validation:
go test ./pkg/cmd/enablessh -timeout 3mpasses, including injected-key/principal cases that verify authorized_keys remains unchanged.Fixes https://linear.app/nvidia/issue/BRE2-1286