Repository navigation
fix: show GPU, disk, and price for create --type --dry-run - #529
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
Fixes brevdev#431 --type --dry-run printed only the type name. Resolve the type in the GPU catalog and print the search table, plus the instance name and org.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #431
brev create <name> --type X --dry-runprinted only the instance type string. That branch never looked the type up, so GPU, disk, price, provider, and org were missing and an agent could not confirm cost before creating.Explicit types are now resolved with
GetInstanceTypesandProcessInstances, in the order given, and rendered with the same table asbrev search(provider, GPU, count, VRAM, disk, hourly price). The instance name and active organization are printed above the table. A disk size already attached to the type is the disk shown. Types that are not in the GPU catalog still print as a name, and nothing is provisioned. CPU-only types stay on that name fallback because the lookup uses the GPU catalog.Tests use the existing mock store. Before the change,
--type g5.xlarge --dry-runoutput was onlyg5.xlarge. After it, the output includes the name, org, GPU, disk, and price, and an unknown type still does not create a workspace.This change was prepared with AI assistance (Claude Code).