Repository navigation
Make our analyses more statistically rigorous - #345
Merged
Merged
Conversation
Instead, just calculate it after the fact, which doesn't require suspect rescaling.
`median` now interpolates like `percentile_from_sorted`, which the two disagreed on for even-length input, so `Summary::median` becomes an `f64`. `std_deviation` uses the sample formula, matching the variance the significance tests already use. Sorting speed ups no longer panics on `NaN`, and `report` defaults to the same significance level as the other subcommands.
These divided by the sum of the two values rather than the baseline, so a 10% regression read 4.76%. Both now use a shared `percent_change`, which `report.rs` had reimplemented with a third, symmetric convention. The p25 delta becomes a median delta, matching the statistic being tested.
Nothing uses this yet.
… for significance
Three samples of a deterministic counter cannot reach a 1% significance level however far apart they lie. Six can.
Member
Author
|
r? @cfallin |
cfallin
approved these changes
Oct 14, 2026
cfallin
left a comment
cfallin
left a comment
Member
There was a problem hiding this comment.
Thanks!
I will freely admit I don't have a deep understanding of the stats here (due to lack of deep background), so all of the actual analysis I will rank as "plausible". But at an implementation level, the code looks fine, so I'm happy to see it merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See each commit for details.