Repository navigation
hotfix: pin MAVROS to 2.16.0 and launch it with an empty namespace (0.20.9) - #435
Closed
JohnYanxinLiu wants to merge 3 commits into
Closed
JohnYanxinLiu wants to merge 3 commits into
JohnYanxinLiu wants to merge 3 commits into
Conversation
pytest 9.2.0 stops at collection with an INTERNALERROR in tests/harness/collection.py:168, so the Python unit and harness contracts check failed on every pull request. Install pytest<9.2 until collection.py works with 9.2 and later. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…space (0.20.9) MAVROS 2.15.0 creates its plugin nodes without the global remaps, so with namespace=mavros their topics and services move to .../mavros/mavros/. Since 2.15.1 MAVROS's node.launch defaults the namespace to empty; ours overrode it. Default it to empty too and pin 2.16.0 (2.15.x drops the px4_config.yaml plugin settings) from the ROS snapshot of 2026-10-05. The main node is now /<robot>/interface/mavros; ready.sh and test_liveliness.py follow. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…o hotfix/mavros-2-16 # Conflicts: # .env # docs/release_notes/index.md
Collaborator
Author
|
Closing: MAVROS stays pinned at 2.14.0 for now (#433). The branch hotfix/mavros-2-16 is kept. This PR's description has the 2.16 evidence for when the pin is lifted: same topic and service names with an empty launch namespace, plugin settings arriving, and the main-node rename. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alternative to #433, which pins MAVROS to 2.14.0. This PR moves to MAVROS 2.16.0 and fixes the launch instead (VERSION → 0.20.11). Only one of #433 and this PR should merge.
Built on #434 (pytest pin, 0.20.10) and merges after it. Until #434 merges, this diff includes its commit.
namespacedefault ofmavrosevery plugin topic and service lands under.../mavros/mavros/<plugin>instead of.../mavros/<plugin>. MAVROS 2.15.1 fixed this in its ownnode.launchby defaultingnamespaceto empty ("since plugin subnodes now properly inherit the UAS namespace").interface_bringup/launch/mavros_px4.launch.xmlstill passesmavrosand overrides that.px4_config.yaml; 2.16.0 fixes that. So the pin is 2.16.0, never 2.15.x. Public Jazzy snapshots: 2026-06-18 has 2.14.0, 2026-09-11 has 2.15.1, 2026-10-05 has 2.16.0.mavros_px4.launch.xml:namespacedefaults to empty.Dockerfile.robotandDockerfile.gcsadd the ROS snapshot of 2026-10-05 and installmavros(andmavros-extrason the robot),mavros-msgs,libmavconnat 2.16.0 andmavlinkat 2026.9.9. The ROS debs do not constrain each other's versions, so all are pinned; the snapshot has them for amd64 and arm64./<robot>/interface/mavrosinstead of/<robot>/interface/mavros/mavros, so the sentinel node in.airstack/modules/ready.shandtests/system/test_liveliness.pyfollows.Evidence
This repository's own launch (
interface_bringup/launch/mavros_px4.launch.xmlunder/robot_1/interface,fcu_urlpointing at nothing), in a throwawayosrf/ros:jazzy-desktop-fullcontainer each, one after the other: 2.14.0 on the old launch against 2.16.0 withnamespaceempty.mavros/terrain/data,mavros/terrain/request)mavros/mavros/.../mavros/<name>state,set_mode,cmd/arming,cmd/takeoff,setpoint_raw/{attitude,local},setpoint_position/{local,global},home_position/{set,home},global_position/{local,global},local_position/odom,extended_state,battery)/robot_1/interface/mavros/mavros/robot_1/interface/mavrosmavros_node,mavros_router.../mavros/mavros_node,.../mavros/mavros_router.../interface/mavros_node,.../interface/mavros_routerterrain/checkserviceParameters,
ros2 param dumpof every MAVROS node: of the 60 plugin nodes present in both, 57 are identical.mission,geofenceandrallypointgainmission_list_timeout,mission_reschedule_time,mission_retriesandmission_wp_timeout, which 2.16 adds. Thepx4_config.yamlvalues arrive on 2.16, for exampletime:timesync_mode: SYSTEM_TIME,time_ref_source: fcu,system_time_rate: 1.0;sys:conn_timeout: 10.0;global_position:frame_id: map,tf.global_frame_id: earth;vision_pose:tf/rate_limit: 10.0. Both versions logTM: Unknown mode: SYSTEM_TIME.Other uses of the main node's name found by grepping the repository:
.airstack/modules/ready.shandtests/system/test_liveliness.py(changed here);tests/meta/test_wiring_snapshot_contract.py(made-up fixture strings, no change); thestacks/*/wiring.mdsnapshots (see Follow-up).Testing
docker build --checkon both Dockerfiles (clean).airstack-ephemeralrunners, which have picked up no job since 2026-09-26, so they will queue.Follow-up
stacks/*/wiring.mdsnapshots from a stack run: they list the old main node names and lack theterraintopics.build_docker,livelinessandtakeoff_hover_landon this PR.🤖 Generated with Claude Code