Skip to content

hotfix: pin MAVROS to 2.16.0 and launch it with an empty namespace (0.20.9) - #435

Closed
JohnYanxinLiu wants to merge 3 commits into
mainfrom
hotfix/mavros-2-16
Closed

JohnYanxinLiu wants to merge 3 commits into
mainfrom
hotfix/mavros-2-16

Conversation

@JohnYanxinLiu

@JohnYanxinLiu JohnYanxinLiu commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Alternative to #433, which pins MAVROS to 2.14.0. This PR moves to MAVROS 2.16.0 and fixes the launch instead (VERSION → 0.20.11). Only one of #433 and this PR should merge.

Built on #434 (pytest pin, 0.20.10) and merges after it. Until #434 merges, this diff includes its commit.

  • Cause. MAVROS 2.15.0 creates its plugin nodes without the global remaps, so with our namespace default of mavros every plugin topic and service lands under .../mavros/mavros/<plugin> instead of .../mavros/<plugin>. MAVROS 2.15.1 fixed this in its own node.launch by defaulting namespace to empty ("since plugin subnodes now properly inherit the UAS namespace"). interface_bringup/launch/mavros_px4.launch.xml still passes mavros and overrides that.
  • Why 2.16.0. 2.15.0 and 2.15.1 also dropped the plugin settings from px4_config.yaml; 2.16.0 fixes that. So the pin is 2.16.0, never 2.15.x. Public Jazzy snapshots: 2026-06-18 has 2.14.0, 2026-09-11 has 2.15.1, 2026-10-05 has 2.16.0.
  • Fix.
    • mavros_px4.launch.xml: namespace defaults to empty.
    • Dockerfile.robot and Dockerfile.gcs add the ROS snapshot of 2026-10-05 and install mavros (and mavros-extras on the robot), mavros-msgs, libmavconn at 2.16.0 and mavlink at 2026.9.9. The ROS debs do not constrain each other's versions, so all are pinned; the snapshot has them for amd64 and arm64.
    • The main node is now /<robot>/interface/mavros instead of /<robot>/interface/mavros/mavros, so the sentinel node in .airstack/modules/ready.sh and tests/system/test_liveliness.py follows.
  • Difference from hotfix: pin MAVROS to 2.14.0 in the robot and GCS images (0.20.9) #433. hotfix: pin MAVROS to 2.14.0 in the robot and GCS images (0.20.9) #433 keeps the old launch and holds MAVROS at 2.14.0. This PR runs the current MAVROS line, and changes the main node's name, the readiness check and one test.

Evidence

This repository's own launch (interface_bringup/launch/mavros_px4.launch.xml under /robot_1/interface, fcu_url pointing at nothing), in a throwaway osrf/ros:jazzy-desktop-full container each, one after the other: 2.14.0 on the old launch against 2.16.0 with namespace empty.

2.14.0, old launch 2.16.0, empty namespace (this PR)
mavros / extras / msgs / libmavconn 2.14.0 2.16.0
mavlink 2026.3.3 2026.9.9
topics 161 163 (extra: mavros/terrain/data, mavros/terrain/request)
topics under mavros/mavros/ 0 0
plugin topic and service names .../mavros/<name> the same
the 15 names the stack uses (state, set_mode, cmd/arming, cmd/takeoff, setpoint_raw/{attitude,local}, setpoint_position/{local,global}, home_position/{set,home}, global_position/{local,global}, local_position/odom, extended_state, battery) present present at the same paths
main node /robot_1/interface/mavros/mavros /robot_1/interface/mavros
mavros_node, mavros_router .../mavros/mavros_node, .../mavros/mavros_router .../interface/mavros_node, .../interface/mavros_router
node count 64 64
terrain/check service absent present

Parameters, ros2 param dump of every MAVROS node: of the 60 plugin nodes present in both, 57 are identical. mission, geofence and rallypoint gain mission_list_timeout, mission_reschedule_time, mission_retries and mission_wp_timeout, which 2.16 adds. The px4_config.yaml values arrive on 2.16, for example time: timesync_mode: SYSTEM_TIME, time_ref_source: fcu, system_time_rate: 1.0; sys: conn_timeout: 10.0; global_position: frame_id: map, tf.global_frame_id: earth; vision_pose: tf/rate_limit: 10.0. Both versions log TM: Unknown mode: SYSTEM_TIME.

Other uses of the main node's name found by grepping the repository: .airstack/modules/ready.sh and tests/system/test_liveliness.py (changed here); tests/meta/test_wiring_snapshot_contract.py (made-up fixture strings, no change); the stacks/*/wiring.md snapshots (see Follow-up).

Testing

  • Run: the container comparison above, and docker build --check on both Dockerfiles (clean).
  • Not run: the images were not built and no flight was run with this change. The image builds and system tests run on the self-hosted airstack-ephemeral runners, which have picked up no job since 2026-09-26, so they will queue.
  • Unit check on this PR (with hotfix: pin pytest below 9.2 in the test requirements (0.20.10) #434's pytest pin): passed, 419 passed and 10 skipped, pytest 9.1.1.

Follow-up

  • Regenerate the stacks/*/wiring.md snapshots from a stack run: they list the old main node names and lack the terrain topics.
  • Run build_docker, liveliness and takeoff_hover_land on this PR.

🤖 Generated with Claude Code

JohnYanxinLiu and others added 3 commits November 17, 2026 14:15
pytest 9.2.0 stops at collection with an INTERNALERROR in
tests/harness/collection.py:168, so the Python unit and harness contracts
check failed on every pull request. Install pytest<9.2 until collection.py
works with 9.2 and later.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…space (0.20.9)

MAVROS 2.15.0 creates its plugin nodes without the global remaps, so with
namespace=mavros their topics and services move to .../mavros/mavros/. Since
2.15.1 MAVROS's node.launch defaults the namespace to empty; ours overrode it.
Default it to empty too and pin 2.16.0 (2.15.x drops the px4_config.yaml
plugin settings) from the ROS snapshot of 2026-10-05. The main node is now
/<robot>/interface/mavros; ready.sh and test_liveliness.py follow.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…o hotfix/mavros-2-16

# Conflicts:
#	.env
#	docs/release_notes/index.md
@JohnYanxinLiu

Copy link
Copy Markdown
Collaborator Author

Closing: MAVROS stays pinned at 2.14.0 for now (#433). The branch hotfix/mavros-2-16 is kept. This PR's description has the 2.16 evidence for when the pin is lifted: same topic and service names with an empty launch namespace, plugin settings arriving, and the main-node rename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant