Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
size-limit report 📦
|
There was a problem hiding this comment.
💡 Codex Review
Line 84 in 1674023
When an incoming message also lists its sender in email.to—for example, from: ['sender@example.com'] and to: [inboxEmail, 'sender@example.com']—this appends that address to cc even though it was already placed in to. Deduplication occurs only within each array, so the result contains the same recipient in both headers, which can cause duplicate delivery or rejection by email providers. Filter the incoming To recipients against the reply's To list before adding them to CC.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1efbb4d4b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
When an incoming email is sent to the inbox and to other people, replying from Chatwoot leaves those other people out. For example, if a customer emails
hello@team.comandengineering@team.com, the reply goes to the customer butengineering@team.comis not added to CC.Replying used to add the email's other To recipients to CC. That was added in #41 for chatwoot/chatwoot#8925. #43 accidentally replaced the incoming email's To list with an empty list, so those recipients were dropped. This PR reads the real To list again.
CC also skips:
HELLO@team.com), so the reply does not CC the inbox itselfBumps the version to
0.0.58.Linear: https://linear.app/chatwoot/issue/CW-8153