Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 9985a74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-native-components
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ClerkJS checks Device Intelligence token expiry against the device's clock, which can discard a fresh token when that clock is ahead or behind the server. Translating the expiry once can also keep an expired token alive locally if that clock is later corrected backward.
Use the loader's server timestamp to establish the remaining lifetime, including time spent loading and awaiting the result. Bound translated tokens by both a monotonic deadline and the translated wall-clock expiry, so a clock correction cannot extend their lifetime. Repeated reads and delayed results keep the original timing reference and expiry margins.
Open pages can share live storage updates by translating the deadline between their time origins without renewing its lifetime. A new page refreshes a persisted result whose timing reference it cannot verify. Each page retains its own usable copy if another page replaces the shared entry. This can require a new check after navigation instead of reusing a persisted translated token. Loaders and entries without timing metadata retain legacy validation, and the existing storage fields remain readable by older runtimes.
Snapshot the highest observed invalidation floor before acquisition. A fresh result from an older page can use that floor, while a result acquired before a later floor change cannot overwrite it. Allow acquisition to retry when the browser clock moves backward past the previous attempt's start time. The token contents and server verification are unchanged.
The additional timing and cache checks add about 0.8 KB compressed per affected entry point compared with the base. Bundle budgets increase as follows:
clerk.js556 to 557 KB,clerk.browser.js83 to 84 KB,clerk.legacy.browser.js126 to 127 KB,clerk.no-rhc.js322.75 to 323.5 KB, andclerk.native.js82.5 to 83 KB.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change