Skip to content

#87 - Client: log each call at debug level, a failed call at error level - #88

Merged
njoubert-cleverage merged 1 commit into
mainfrom
87
Nov 6, 2026
Merged

njoubert-cleverage merged 1 commit into
mainfrom
87

Conversation

@njoubert-cleverage

Copy link
Copy Markdown
Member

Description

Fixes #87: the Client logs each call at debug level (was notice) and a failed call (SoapFault) at error level (was alert), as the RequestTask and the REST client.

  • documentation of the client, UPGRADE (Log levels of the client, under Latest);
  • RequestTaskTest: the assertions on the error log of the task select its message (Soap call failed), the failure of the client being now logged at error level too.

Note, not changed: a call failing through RequestTask is logged twice, by the client (message, masked request / response trace) and by the task (masked options, last request / response) — it was already the case, at alert then error level.

Checked locally: highest dependencies (PHP 8.5.12), with pcov coverage: all tests OK, no risky; PHPStan, PHP-CS-Fixer and Rector OK.

Requirements

  • Documentation updates
    • Reference
    • Cookbooks
    • Changelog
  • Unit tests

Breaking changes

The log levels change (notice → debug, alert → error), see UPGRADE.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@njoubert-cleverage
njoubert-cleverage requested a review from a team as a code owner November 6, 2026 16:04
@njoubert-cleverage
njoubert-cleverage merged commit 8136fbc into main Nov 6, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SOAP client: log levels out of line with the request task and the REST client (notice for each call, alert for a failure)

1 participant