Skip to content

fix(images): upgrade apt in minimal and universal for CVE-2026-109518 - #345

Merged
matifali merged 2 commits into
mainfrom
fix/apt-upgrade-minimal-universal
Nov 5, 2026
Merged

matifali merged 2 commits into
mainfrom
fix/apt-upgrade-minimal-universal

Conversation

@matifali

@matifali matifali commented Nov 5, 2026

Copy link
Copy Markdown
Member

Problem

The minimal and universal images don't run apt-get upgrade, and their upstream images (ubuntu:resolute, mcr.microsoft.com/devcontainers/universal:noble) still ship apt without the CVE-2026-109518 fix (USN-8996-1). A rebuild alone won't fix them. Desktop builds on minimal.

Fix

  • minimal: add apt-get upgrade to the existing install step, matching base.
  • universal: add an apt-get update && apt-get upgrade step right after USER root.
  • desktop: no change. It uses FROM codercom/enterprise-minimal:latest, and scripts/images.sh builds minimal first.

Validation

Built locally and checked dpkg-query -W apt:

Image Upstream apt With this change
minimal (ubuntu:resolute) 3.2.0 3.2.1ubuntu0.1
universal (devcontainers/universal:noble) 2.8.3 2.8.4ubuntu0.1

For universal, I only built the upstream image plus the new upgrade step, not the later steps.

Note

Acquire::Retries "0" is left out on purpose. With apt upgraded it isn't needed, and it would make apt installs in user workspaces fail on temporary network errors instead of retrying.

After merge, trigger build.yaml by hand rather than waiting for the weekly scheduled run.

Closes SEC-1319
Part of SEC-1315

🤖 This PR was created with the help of Coder Agents, and needs a human review. 🧑💻

@linear-code

linear-code Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

SEC-1315

SEC-1319

@matifali
matifali requested a review from Lisa-Fiander November 5, 2026 13:41
Comment thread images/universal/ubuntu.Dockerfile Resolved
@matifali
matifali requested review from Lisa-Fiander and removed request for Lisa-Fiander November 5, 2026 13:46
@matifali
matifali merged commit 4848104 into main Nov 5, 2026
2 checks passed
@matifali
matifali deleted the fix/apt-upgrade-minimal-universal branch November 5, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants