Repository navigation
revert(universal): drop PHP rebuild override now that upstream ships patched PHP - #347
Merged
Merged
Conversation
…patched PHP The upstream devcontainers/universal:noble image (release v0.4.37) now ships PHP 8.5.12 and 8.4.27, so rebuilding PHP from source is no longer needed. The session.upload_progress hardening step is kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream now ships patched PHP, so our temporary rebuild override from #343 is no longer needed. The fix landed in devcontainers/images@088f414 (devcontainers/images#2059), which pins PHP 8.5.12 / 8.4.27, and shipped in release v0.4.37.
mcr.microsoft.com/devcontainers/universal:nobleis now that release.Changes
PHP_*ARGs) fromimages/universal/ubuntu.Dockerfile.session.upload_progress.enabled=0hardening from chore(universal): disable PHP session upload progress #344; it applies to every/usr/local/php/[0-9]*version in the upstream install.Validation
mcr.microsoft.com/devcontainers/universal:noble:dev.containers.release=v0.4.37, created 2026-10-28./usr/local/phpcontains8.4.27,8.5.12,current;php -vreports 8.4.27.docker build -f images/universal/ubuntu.Dockerfile images/universalsucceeds. In the built image, the user iscoder,php -vreports 8.4.27, andsession.upload_progress.enabledis0for both 8.4.27 and 8.5.12.dprint checkpasses.Closes: CLIENT-1060