Repository navigation
Conversation
Rebinding the client to another deployment or account cancels its pending requests, while token refreshes keep them. The auth interceptor no longer refreshes, prompts or retries for a request canceled by a session change.
A remote window keeps pending requests only when a new token belongs to the same user and URL; otherwise it rebinds and resets OAuth. A refresh canceled during its user lookup no longer persists over replacement credentials.
Collaborator
Author
EhabY
force-pushed
the
fix/workspace-session-isolation
branch
from
November 9, 2026 12:01
ae9c9e4 to
750c24d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1174. Not a prerequisite for #1168, so it can land after it.
#1174 cancels pending requests whenever the client rebinds. Remote windows there keep requests for any token on the same URL. This PR verifies the token's user first and closes the OAuth gap that lets an old account's refresh win.
Implementation decisions
AbortController, so superseded or disposed lookups never apply credentials.OAuthSessionManager.setDeploymentcompares deployment identity, so rebinding to a new account on the same URL aborts the in-flight refresh. A refresh aborted during its user lookup no longer persists, and only the current refresh clears the shared promise.🤖 Generated with Claude Code