Skip to content

bind-mount: Preserve nosymfollow across flag fixup - #833

Open
iamda-y wants to merge 2 commits into
containers:mainfrom
iamda-y:contrib/nosymfollow-770
Open

iamda-y wants to merge 2 commits into
containers:mainfrom
iamda-y:contrib/nosymfollow-770

Conversation

@iamda-y

@iamda-y iamda-y commented Nov 15, 2026

Copy link
Copy Markdown

This follows up on #770 by Tomas Junnonen.
I've added a separate commit improving the regression test.
I've rebased their original fix onto current main, preserving their authorship and sign-off.

The original test could pass even if namespace or mount setup failed, without exercising the regression. #770 (comment)
The updated test checks that the source mount rejects symlink traversal and that the sandboxed child reaches ELOOP. It covers both the normal path and the forced mount_setattr() fallback when available, with explicit skips for unsupported cases.

tjunnone and others added 2 commits November 15, 2026 16:00
Add a nosymfollow entry to decode_mountoptions so the flag is not
dropped on a fixup remount.

Added a regression test, binding a `nosymfollow` tmpfs read-only
(therefore forcing a fixup remount) that fails if symlink is
followed.

Signed-off-by: Tomas Junnonen <tomas1@gmail.com>
(cherry picked from commit 3579e14)
The existing test could pass when namespace or mount setup failed,
without exercising the regression.

Check the source mount's behavior and require the sandboxed child
to reach ELOOP through both the normal and forced-fallback paths.
Report unavailable prerequisites and compiled-out fallback coverage
as skips.

Signed-off-by: iamda-y <lambdaecorporation@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants