Repository navigation
Conversation
Add a nosymfollow entry to decode_mountoptions so the flag is not dropped on a fixup remount. Added a regression test, binding a `nosymfollow` tmpfs read-only (therefore forcing a fixup remount) that fails if symlink is followed. Signed-off-by: Tomas Junnonen <tomas1@gmail.com> (cherry picked from commit 3579e14)
The existing test could pass when namespace or mount setup failed, without exercising the regression. Check the source mount's behavior and require the sandboxed child to reach ELOOP through both the normal and forced-fallback paths. Report unavailable prerequisites and compiled-out fallback coverage as skips. Signed-off-by: iamda-y <lambdaecorporation@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up on #770 by Tomas Junnonen.
I've added a separate commit improving the regression test.
I've rebased their original fix onto current main, preserving their authorship and sign-off.
The original test could pass even if namespace or mount setup failed, without exercising the regression. #770 (comment)
The updated test checks that the source mount rejects symlink traversal and that the sandboxed child reaches ELOOP. It covers both the normal path and the forced
mount_setattr()fallback when available, with explicit skips for unsupported cases.