Repository navigation
Conversation
ao2
left a comment
There was a problem hiding this comment.
The changes look good to me, I only have one comment.
ao2
left a comment
There was a problem hiding this comment.
If @domenkozar agrees, let's squash the commits to have a cleaner history, and @iamda-y can add another Signed-off-by: or a Co-authored-by: tag to the commit message.
And I think we can also remove the note about (cherry picked from commit 6e558d4 ) from the commit message, when the original PR will be rebased after this gets merged that commit ID will become less relevant.
If your really want to add some reference you could mention the PR where this is taken from, but even that might not be strictly necessary.
Thanks, Antonio.
|
Sounds good to me! |
Read the filesystem type from /proc/self/mounts instead of letting libc write a complete, architecture-dependent statfs structure into a two-field ctypes buffer. Validation: all six Meson suites pass in Debian trixie with warnings as errors, SELinux, ASan, UBSan and PYTHONMALLOC=debug. Signed-off-by: Domen Kožar <domen@cachix.org> Signed-off-by: iamda-y <lambdaecorporation@gmail.com>
a6aa4e6 to
fb04d21
Compare
|
Cleanup has been completed. |
ao2
left a comment
There was a problem hiding this comment.
FWIW, the change looks good to me.
|
The modified |
|
I don't know why the pipeline is failing, but it did seem to be genuinely failing. Sorry, I cannot currently allocate time to debug this. |
This splits Domen Kožar's fix from #788 into a separate PR, following smcv's request.
The test helper previously passed an undersized
ctypesbuffer tostatfs(), which writes the full native structure. The fix reads the filesystem type from/proc/self/mountsinstead.