Repository navigation
OpenCode 1: a response no longer waits for the sidebar update - #848
Closed
antauth-alfonso[bot] wants to merge 2 commits into
Closed
antauth-alfonso[bot] wants to merge 2 commits into
antauth-alfonso[bot] wants to merge 2 commits into
Conversation
Keep route attribution ordered across detached account reloads and drain pending route writes within the existing advisory shutdown grace. Extend the sticky model-reselection test with a held reload and stale-write race, and explicitly wait in sidebar assertions that used to rely on fetch completion.
ualtinok
added a commit
that referenced
this pull request
Nov 18, 2026
Author
|
Squash-merged to main as 635c126. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sticky, fallback/API-key and main completions awaited writeCurrentSidebarState (account reload + sidebar write) before returning the response. Now detached, ordered by request sequence so a late older write can't overwrite a newer state, failures logged once with a fixed message, and flushed within the dispose grace. Baseline test failed with 'Sticky response waited for the sidebar account reload'.
Summary by cubic
Makes OpenCode 1 route sidebar updates async so a response no longer waits for the sidebar write (account reload + state file write) to finish before returning.
Written for commit c1d6071. Summary will update on new commits.