Repository navigation
feat(assets): support ID filters in asset search - #5
Merged
Merged
Conversation
bd-corva
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asset searches currently require callers to build list parameters manually to retrieve multiple known IDs. Add keyword-only
ids: Sequence[int] | Nonetoassets.search(), serialized as repeatedids[]parameters alongside the existing filters, field selection, and pagination.Reject empty sequences and non-positive or non-integer IDs before making a request, including booleans and string values. Omitted IDs preserve existing behavior and positional compatibility. Document usage and cover list/tuple inputs, HTTP query encoding, combined filters, invalid inputs, and default behavior. Application-specific batch limits remain with consumers.
This enables corva-ai/corva-cli#109 to use the shared search helper instead of duplicating parameter serialization. The local API controller accepts ID filtering on its permission-scoped relation; no live API calls were made.
Validation: independent read-only review found no actionable issues. Final
just checkpassed formatting, lint, type checks, and all 83 tests;git diff --checkpassed.