Repository navigation
Add solver specific docs for fast path flow - #676
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fhenneke
left a comment
There was a problem hiding this comment.
Warning
This review was written by Claude (AI), not by Felix. It is posted from @fhenneke's account at his request. It applies Odran's cow-public-wording-review skill (from the KSS "Writing About CoW Protocol Accurately") and checks technical claims against cowprotocol/services main. Treat it as input to verify, not as Felix's own review.
Wording review of fast_path_flow.md. The main pattern: the page uses "the protocol" as the actor and describes the solver as executing the order and delivering amounts to the user. The skill asks for the exact actor, action and stage instead (Autopilot selects the winner, the driver submits a transaction, the order is filled if that transaction succeeds on-chain). Inline suggestions below.
Two points to confirm:
- Is
enableFastPathread from theappDataof the quote request?servicesparses it fromappData.metadatafor orders, and the concepts page says the same. If so, say that and link the app-data reference instead of "a flag in each quote request". - With the fast-path penalty cap at zero, does an unfilled fast-path auction currently yield neither penalty nor reward? That is my reading of the cap formula in the rewards section. If correct, the suggestion on line 14 states it.
Co-authored-by: Felix Henneke <felix.henneke@protonmail.com>
Co-authored-by: Felix Henneke <felix.henneke@protonmail.com>
Co-authored-by: Felix Henneke <felix.henneke@protonmail.com>
Co-authored-by: Felix Henneke <felix.henneke@protonmail.com>
Co-authored-by: Felix Henneke <felix.henneke@protonmail.com>
This PR adds some minimal documentation around the fast-path flow, intended for solvers