Skip to content

Add solver specific docs for fast path flow - #676

Merged
harisang merged 10 commits into
mainfrom
add_fast_path_solver_documentation
Oct 26, 2026
Merged

harisang merged 10 commits into
mainfrom
add_fast_path_solver_documentation

Conversation

@harisang

Copy link
Copy Markdown
Contributor

This PR adds some minimal documentation around the fast-path flow, intended for solvers

@harisang
harisang requested a review from a team as a code owner October 23, 2026 12:39
@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 23, 2026 11:27pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: df78788d-7cec-4ce9-8827-f82ae4269653
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fhenneke fhenneke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

This review was written by Claude (AI), not by Felix. It is posted from @fhenneke's account at his request. It applies Odran's cow-public-wording-review skill (from the KSS "Writing About CoW Protocol Accurately") and checks technical claims against cowprotocol/services main. Treat it as input to verify, not as Felix's own review.

Wording review of fast_path_flow.md. The main pattern: the page uses "the protocol" as the actor and describes the solver as executing the order and delivering amounts to the user. The skill asks for the exact actor, action and stage instead (Autopilot selects the winner, the driver submits a transaction, the order is filled if that transaction succeeds on-chain). Inline suggestions below.

Two points to confirm:

  • Is enableFastPath read from the appData of the quote request? services parses it from appData.metadata for orders, and the concepts page says the same. If so, say that and link the app-data reference instead of "a flag in each quote request".
  • With the fast-path penalty cap at zero, does an unfilled fast-path auction currently yield neither penalty nor reward? That is my reading of the cap formula in the rewards section. If correct, the suggestion on line 14 states it.

Comment thread docs/cow-protocol/reference/core/auctions/fast_path_flow.md Outdated
Comment thread docs/cow-protocol/reference/core/auctions/fast_path_flow.md Outdated
Comment thread docs/cow-protocol/reference/core/auctions/fast_path_flow.md Outdated
Comment thread docs/cow-protocol/reference/core/auctions/fast_path_flow.md Outdated
Comment thread docs/cow-protocol/reference/core/auctions/fast_path_flow.md Outdated
Co-authored-by: Felix Henneke <felix.henneke@protonmail.com>
Co-authored-by: Felix Henneke <felix.henneke@protonmail.com>
Co-authored-by: Felix Henneke <felix.henneke@protonmail.com>
Co-authored-by: Felix Henneke <felix.henneke@protonmail.com>
Co-authored-by: Felix Henneke <felix.henneke@protonmail.com>
@harisang
harisang merged commit 69d6107 into main Oct 26, 2026
5 checks passed
@harisang
harisang deleted the add_fast_path_solver_documentation branch October 26, 2026 09:55
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 26, 2026

This branch was successfully deployed

1 active deployment
Preview — bef62f05 Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants