Repository navigation
Repro dnix packages - #1505
Draft
julian-CStack wants to merge 14 commits into
Draft
Repro dnix packages#1505julian-CStack wants to merge 14 commits into
julian-CStack wants to merge 14 commits into
Conversation
added 2 commits
November 9, 2026 10:01
Pin the merged Frost, Tor, Epic and MWC packages. Configure verified source builds by default and verified prebuilts with -d, including before asset generators can execute hooks. Handle native Windows secp256k1 builds, raise the macOS deployment target to 12, keep CI on prebuilts, remove obsolete Rust setup, and refresh build requirements. Add app/mode and host dispatch regression coverage. Validation: 39 script tests and 8 Apple Silicon native consumer smoke tests passed; all three app dependency sets resolve; generated adapters and the new tests analyze cleanly; workflow lint, formatting and shell syntax checks pass. Full app and Windows/WSL builds were not run locally.
Document xcodes and Apple download installation alongside existing Xcode versions, using DEVELOPER_DIR for builds without changing the system default. Launch installation in a separate Terminal session with a clean environment. Download using xcodes --no-superuser, then invoke only the selected xcodebuild via sudo -k so sudo reads the administrator password and does not cache authorization. Never run build commands from the installer. Validation: 10 fixture tests passed, including environment isolation, shell/AppleScript quoting, reuse and failure paths. Dart analysis, formatting, shell syntax and workflow lint pass. No real Xcode installation or privileged setup was run.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## staging #1505 +/- ##
===========================================
+ Coverage 14.08% 15.02% +0.94%
===========================================
Files 1139 1140 +1
Lines 114742 114098 -644
===========================================
+ Hits 16156 17144 +988
+ Misses 98586 96954 -1632 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
added 4 commits
November 10, 2026 10:18
Keep Rustup for DNSSEC in every app and CI job. Check prerequisites before replacing configuration, persist WSL selection through an environment default or -w, and correct the docs about executable hook closures and DEVELOPER_DIR. Build Windows secp256k1 independently of dnix mode using one pinned v0.5.0 source for MSVC and MinGW. Discover VS CMake and SDK tools, stop on failed commands, and reuse only matching local build receipts. Fix PowerShell prebuild paths, malformed stubs and write failures. Select the Xcode 27.0 release build, support xcodes outside Homebrew, launch a shell-portable installer in one Terminal session, and keep results visible. Detect dnix's separate beta-selection limitation without changing global Xcode settings. Inject native tools into tests instead of rewriting privileged command strings. Validation: 92 targeted Dart tests and 4 PowerShell regression cases passed; Dart analysis/formatting, Bash syntax, workflow lint and diff checks passed. No full native Windows app build or privileged Xcode installation ran. Package-level xcodeBuild pins remain a documented upstream follow-up.
Preserve Windows build results when cleanup fails, remove unused Docker Rust toolchain layers, and reject package-local dnix mode overrides on the actual Flutter host. Read Xcode requirements from pinned dependency metadata with revision-specific compatibility for packages missing build pins. Share WSL validation, check dependency contracts, simplify hook settings, and update setup guidance. Validation: Dart analysis and formatting, Bash syntax, actionlint, and git diff --check. Final changes were validated statically only; new regression tests and native Windows/Build workflow execution remain pending. Upstream Xcode build-number pins are still needed.
Exclude uppercase /C and mklink /D from MSYS argument conversion per command, preserving existing user exclusions. Apply the same fix to Windows CI asset cleanup. Keep native path conversion and failure handling in place. Validation: Bash syntax, actionlint, whitespace checks, and independent static review. Native Windows execution remains unverified; no changes to dnix lock handling.
|
Compatibility check from my side while drafting #1482:
I did not merge your draft into #1482; it stays independent until this PR is ready. No action needed from you right now — just flagging the overlap. |
added 3 commits
November 12, 2026 07:11
The xcodesorg/made tap no longer installs on macOS 27: Homebrew 7 cannot match its mojave bottle tags, and its source build fails with the Swift 6.4 toolchain. The homebrew-core formula ships a macOS 27 bottle. Validation: xcode_setup_test.dart passes. brew install xcodes was not run on a real machine.
Select Isar's Rust toolchain explicitly, filter Xcode metadata by app, and preserve Windows Dart PATH precedence. Remove secp receipt caching and update focused tests and docs. Validation: Dart analysis, formatting, shell syntax, and git diff --check passed. Regression tests and native builds were not executed.
|
Build-compatibility update: I test-merged
The throw-away merge was removed; #1482 is untouched. |
Native Windows Flutter always builds the app, and Git Bash is already the documented route and the one CI uses. Remove the legacy WSL-shell configuration route: build_app.sh and the preflight reject Windows configuration from other hosts, the override guard no longer dispatches to PowerShell and takes only the app, and the preflight no longer probes Windows Rustup through cmd.exe. Build secp256k1 with MSVC only, removing its WSL wrapper and the orphaned MinGW deps script. Call cygpath, flutter and dart directly in the asset scripts. Build mwebd.exe from source only on Windows (fetching still works anywhere) and drop MinGW from the CI image. dnix and the MWEB helper still use WSL2 as their Windows build backend. Validation: build_input, native_build_config, configure_native_assets, build_environment, windows_secp_build and xcode_setup tests pass on macOS; native_dependency_contract fails only its app-package metadata test, as on the parent commit. Dart analysis with the repo lints, formatting, Bash syntax, and git diff --check passed. Nothing was run on Windows, and the Windows release workflow has not run.
Reject iOS and macOS targets on non-macOS hosts before the prebuilt early return, so -d can no longer start configuring Apple builds on Linux or Windows. Reject an empty -w instead of letting it silently replace DNIX_WSL_DISTRIBUTION with the WSL default; the Dart validator already refuses empty names. List Go and mingw-w64 in the default WSL distribution among the Windows prerequisites for Stack Wallet's MWEB build. Compare the secp test's checkout directory with platform-aware paths so the test passes on native Windows. Validation: build_input, native_build_config, configure_native_assets, build_environment, windows_secp_build and xcode_setup tests pass on macOS; native_dependency_contract fails only its app-package metadata test, which needs the app's flutter pub get. The new tests fail when the Apple host rule or the -w check is removed. Dart analysis with the repo lints, formatting, Bash syntax, and git diff --check passed. Nothing was run on Windows.
Delete scripts/windows/build_secp256k1.bat, which nothing calls now that Windows configuration runs from Git Bash. Drop the pushd/popd around the secp256k1 helper in build_app.sh: the helper locates the project from its own path and gives its commands explicit working directories, so the configuration test now checks only where the DLL lands. Keep only the Windows SDK version the helper passes to CMake, dropping the unused SDK root. Validation: build_input, native_build_config, configure_native_assets, build_environment, windows_secp_build and xcode_setup tests pass on macOS; native_dependency_contract fails only its app-package metadata test, which needs the app's flutter pub get. Dart analysis with the repo lints reports only an existing info lint; formatting, Bash syntax, and git diff --check passed. Nothing was run on Windows.
Stop documenting -s, which only CI uses, and explain it next to the CI steps that need it. Document that -d ignores native edits in a locked local checkout, that source mode on a Mac needs Xcode 27.0 for every target, the manual Xcode name the setup helper uses, and Android release signing. Load the pinned Xcode metadata only on an Apple Silicon Mac, where it is used, and advise checking the network connection when the download fails. Check for Go and MinGW in the default WSL distribution before configuring Stack Wallet for Windows, unless MWEBD_FETCH=1 or CI applies. Run flutter pub get on Linux before the second override check. Read vswhere output as UTF-8. Make the Xcode ordering tests fail when the ordering logic breaks, and correct a misleading CI comment about symlink permissions. Validation: build_input, native_build_config, configure_native_assets, build_environment, windows_secp_build and xcode_setup tests pass on macOS; native_dependency_contract fails only its app-package metadata test, which needs the app's flutter pub get. The new tests fail when the sort, the setup helper's conflict check, the MWEB check, the Apple Silicon condition, -utf8 or the Linux pub get is removed. Dart analysis with the repo lints reports only an existing info lint; formatting, Bash syntax, workflow YAML and git diff --check passed. The preflight passes on an Apple Silicon Mac for Android prebuilt and iOS source. Nothing was run on Windows or on a Linux host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.