Skip to content

Electrum client per wallet refactor - #1510

Merged
julian-CStack merged 25 commits into
stagingfrom
electrum-client-per-wallet-refactor
Nov 13, 2026
Merged

Electrum client per wallet refactor#1510
julian-CStack merged 25 commits into
stagingfrom
electrum-client-per-wallet-refactor

Stop describing a certificate approval as a pin

4b88ce9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 13, 2026 in 1s

16.08% (+2.00%) compared to 6c49e3c

View this Pull Request on Codecov

16.08% (+2.00%) compared to 6c49e3c

Details

Codecov Report

❌ Patch coverage is 78.60465% with 184 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.08%. Comparing base (6c49e3c) to head (4b88ce9).
⚠️ Report is 5 commits behind head on staging.

Files with missing lines Patch % Lines
...gs_view/manage_nodes_views/add_edit_node_view.dart 69.32% 50 Missing ⚠️
...ngs_view/manage_nodes_views/node_details_view.dart 75.86% 21 Missing ⚠️
lib/utilities/test_node_connection.dart 0.00% 17 Missing ⚠️
...ore_wallet_view/restore_view_only_wallet_view.dart 0.00% 16 Missing ⚠️
lib/services/node_service.dart 86.36% 15 Missing ⚠️
lib/wallets/wallet/impl/bitcoin_frost_wallet.dart 0.00% 14 Missing ⚠️
lib/widgets/node_card.dart 67.56% 12 Missing ⚠️
...t/wallet_mixin_interfaces/electrumx_interface.dart 60.86% 9 Missing ⚠️
lib/utilities/test_monero_node_connection.dart 30.00% 7 Missing ⚠️
...views/restore_wallet_view/restore_wallet_view.dart 0.00% 6 Missing ⚠️
... and 7 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           staging    #1510      +/-   ##
===========================================
+ Coverage    14.08%   16.08%   +2.00%     
===========================================
  Files         1139     1145       +6     
  Lines       114742   114390     -352     
===========================================
+ Hits         16156    18401    +2245     
+ Misses       98586    95989    -2597

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov