Repository navigation
refactor: share the send fee logic across send's view - #1511
Merged
julian-CStack merged 3 commits intoNov 12, 2026
Merged
Conversation
Cyrix126
force-pushed
the
share_send_fee_logic
branch
from
November 12, 2026 16:20
b9a8419 to
32f6083
Compare
sneurlax
requested changes
Nov 12, 2026
sneurlax
left a comment
sneurlax
left a comment
Member
There was a problem hiding this comment.
Thanks for consolidating this logic and adding substantial test coverage. The direction looks good.
I’m requesting two focused fixes before merging: invalidate temporary fee estimates when wallet readiness changes, and guard the chooser continuation against form disposal. The focused suite passes, but the two additional regression cases described inline fail.
Cyrix126
force-pushed
the
share_send_fee_logic
branch
from
November 12, 2026 21:06
32f6083 to
92c4d65
Compare
Cyrix126
force-pushed
the
share_send_fee_logic
branch
from
November 12, 2026 21:15
92c4d65 to
f9ec2c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
share the code for the fee form in sends view, reducing loc, fixing bugs and unifying different behaviors between platforms.
All bug fixed have a test failing without this refactor.