Repository navigation
Fix Linux app icons - #1513
Open
sneurlax wants to merge 7 commits into
Open
Fix Linux app icons#1513sneurlax wants to merge 7 commits into
sneurlax wants to merge 7 commits into
Conversation
The runner never set a window icon, so X11 taskbars and alt-tab only showed one when a desktop file happened to match WM_CLASS. Install the app's icon.png as data/app_icon.png and load it at startup. GTK3 caps _NET_WM_ICON at 262144 longs and silently drops anything larger. A single 512x512 image needs 262146, so pass 16 to 256 px copies instead. The same limit means gtk_window_set_icon_name() with only a 512x512 themed icon also sets nothing.
Add <launchable> so appstream tooling can tie the component to the desktop file and its icon.
The running window reports com.cypherstack.<app> as its app ID and WM_CLASS, but the AppImage desktop entry was <app>.desktop with Icon=<app>, so nothing matched it to the window, even after Gear Lever or AppImageLauncher installed it. Name the entry and icon after the app ID and add StartupWMClass, which still matches when integrators rename the file. appimage/make_appdir.sh now builds the AppDir for all three CI jobs: root icon plus .DirIcon, usr/share/icons/hicolor, usr/share/applications, and the flatpak metainfo as usr/share/metainfo/<id>.appdata.xml, which appimagetool validates with appstreamcli when it is installed.
AppImageKit is archived. The maintained appimagetool embeds the static type2 runtime, so the AppImages no longer need libfuse2 on the user's system.
appimagetool validates usr/share/metainfo with appstreamcli, which fetches every <url>. campfireprivacy.com no longer resolves, so the Campfire AppImage build failed, and any site being down would fail the others. Flatpak builds keep the metainfo; flatpak-builder does not fetch URLs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## staging #1513 +/- ##
===========================================
+ Coverage 14.08% 15.02% +0.94%
===========================================
Files 1139 1140 +1
Lines 114742 114098 -644
===========================================
+ Hits 16156 17145 +989
+ Misses 98586 96953 -1633 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.