Repository navigation
fix: preserve precheck causes and classify unreadable ref audits (#510) - #513
Conversation
|
Implemented #510 at
Verification below is agent-reported. The final full suite passed (2,663 tests, one skipped); the earlier failed attempts remain in the check history. {
"tests": {
"version": 2,
"ran": true,
"passed": true,
"conclusion": "verified",
"boundary": "required",
"checks": [
{
"id": "configured-test",
"command": "python3 -m unittest discover -s tests",
"executor": "codex",
"profile": "deep_coder",
"context": "project",
"required": true,
"criteria": [
"AC-1",
"AC-2",
"AC-3",
"AC-4"
],
"level": "test",
"provenance": "project",
"reason": "configured test command",
"head_sha": "aef0cf4a6077c7748819bbf8a14b6e6363f9825d",
"result": "pass",
"evidence": [
{
"exit_code": 0,
"executed": 2663
}
],
"cause": "",
"attempts": [
{
"result": "fail",
"evidence": [
{
"exit_code": 1,
"executed": 2658
}
],
"cause": "Intermediate Git helper behavior; corrected before the subsequent runs."
},
{
"result": "fail",
"evidence": [
{
"exit_code": 1,
"executed": 2663
}
],
"cause": "Missing test registrations and four old stop expectations, now fixed; two consent time-budget errors also passed on isolated rerun."
}
]
},
{
"id": "validate-package",
"command": "python3 scripts/validate-package.py",
"executor": "codex",
"profile": "deep_coder",
"context": "project",
"required": true,
"criteria": [],
"level": "static",
"provenance": "project",
"reason": "configured verification command",
"head_sha": "aef0cf4a6077c7748819bbf8a14b6e6363f9825d",
"result": "pass",
"evidence": [
{
"exit_code": 0,
"executed": null
}
],
"cause": "",
"attempts": []
},
{
"id": "unittest-default",
"command": "python3 -m unittest",
"executor": "codex",
"profile": "deep_coder",
"context": "project",
"required": true,
"criteria": [],
"level": "test",
"provenance": "project",
"reason": "configured verification command",
"head_sha": "aef0cf4a6077c7748819bbf8a14b6e6363f9825d",
"result": "pass",
"evidence": [
{
"exit_code": 0,
"executed": 0
}
],
"cause": "",
"attempts": []
},
{
"id": "basedpyright",
"command": "basedpyright",
"executor": "codex",
"profile": "deep_coder",
"context": "project",
"required": true,
"criteria": [],
"level": "static",
"provenance": "project",
"reason": "configured verification command",
"head_sha": "aef0cf4a6077c7748819bbf8a14b6e6363f9825d",
"result": "pass",
"evidence": [
{
"exit_code": 0,
"executed": null
}
],
"cause": "",
"attempts": []
},
{
"id": "precheck-regressions",
"command": "python3 -m unittest discover -s tests -p test_precheck_causes.py",
"executor": "codex",
"profile": "deep_coder",
"context": "project",
"required": true,
"criteria": [
"AC-1",
"AC-2",
"AC-3",
"AC-4"
],
"level": "boundary",
"provenance": "agent",
"reason": "redacted failures, retry evidence, real failing Git subprocess and inventory coverage",
"head_sha": "aef0cf4a6077c7748819bbf8a14b6e6363f9825d",
"result": "pass",
"evidence": [
{
"exit_code": 0,
"executed": 11
}
],
"cause": "",
"attempts": []
},
{
"id": "manifest-regressions",
"command": "python3 -m unittest discover -s tests -p test_fast_path.py",
"executor": "codex",
"profile": "deep_coder",
"context": "project",
"required": true,
"criteria": [
"AC-3",
"AC-4"
],
"level": "test",
"provenance": "agent",
"reason": "register the inventory test with fast-path and Windows shard guards",
"head_sha": "aef0cf4a6077c7748819bbf8a14b6e6363f9825d",
"result": "pass",
"evidence": [
{
"exit_code": 0,
"executed": 42
}
],
"cause": "",
"attempts": []
},
{
"id": "dispatch-compatibility",
"command": "python3 -m unittest discover -s tests -p test_dispatch_failures.py",
"executor": "codex",
"profile": "deep_coder",
"context": "project",
"required": true,
"criteria": [
"AC-2",
"AC-4"
],
"level": "test",
"provenance": "agent",
"reason": "audit-unavailable classification without starting an attempt",
"head_sha": "aef0cf4a6077c7748819bbf8a14b6e6363f9825d",
"result": "pass",
"evidence": [
{
"exit_code": 0,
"executed": 30
}
],
"cause": "",
"attempts": []
},
{
"id": "consent-regression",
"command": "python3 -m unittest discover -s tests -p test_consent_variants.py -k test_rev016_bash_baseline_and_real_hook_allow_and_deny",
"executor": "codex",
"profile": "deep_coder",
"context": "project",
"required": true,
"criteria": [],
"level": "test",
"provenance": "agent",
"reason": "rerun the time-budget errors without competing full-suite execution",
"head_sha": "aef0cf4a6077c7748819bbf8a14b6e6363f9825d",
"result": "pass",
"evidence": [
{
"exit_code": 0,
"executed": 1
}
],
"cause": "",
"attempts": []
}
]
}
}Checks of the pushed head were read once under the parallel CI policy; both were queued and remain pending in this report. {
"checks": {
"head_sha": "aef0cf4a6077c7748819bbf8a14b6e6363f9825d",
"passed": 0,
"failed": 0,
"pending": 2,
"items": [
{
"name": "Classify the change",
"state": "pending"
},
{
"name": "Skills, manifests, and Bash installer",
"state": "pending"
}
]
}
} |
[CCR-20261118-001] · senior_reviewer · anthropic/claude-opus-5-5→? · high · schema:2Initial review of #513 at Full accumulated diff vs
Review details, verification and receiptScopeThe runtime supplied the diff: base
FindingsNone. No earlier review findings exist on this change request, so no IDs were recovered. Acceptance criteria
Notes (non-blocking, not findings)
SecurityThe plan has No confirmed vulnerability was found. Reviewed surfaces:
Residual risk: redaction is pattern-based, so it is not proof that arbitrary provider diagnostics contain no sensitive data. Verification (head
|
| Check | Command | Exit | Result |
|---|---|---|---|
| configured-test | python3 -m unittest discover -s tests |
0 | Ran 2663 tests in 651.376s, OK (skipped=1) |
| verify:validate-package | python3 scripts/validate-package.py |
0 | VALID: 16 skills |
| verify:unittest | python3 -m unittest |
0 | Ran 0 tests, OK |
| verify:basedpyright | basedpyright |
0 | 0 errors, 0 warnings, 0 notes |
| targeted | python3 -m unittest discover -s tests -p test_precheck_causes.py -v |
0 | 11 tests OK |
Not verified: no live GitHub or remote outage was reproduced. Provider failures were exercised through injected subprocess results. The Git exit-128 boundary ran against a real local repository.
CI (parallel policy, read once, not waited on)
| Check | State |
|---|---|
| Classify the change | pass |
| Skills, manifests, and Bash installer | pass |
| Windows test shard (windows-1) | pass |
| Windows test shard (windows-2) | pass |
| Windows test shard (windows-4) | pass |
| Windows test shard (windows-3) | pending |
test_precheck_causes is assigned to shard windows-4, which passed.
Documentation
docs/role-workspace-policy.md documents the retry, the stop and the evidence fields. docs/capability-parity-audit.md contains the inventory. The change adds no new veto row.
Closes #510.
Diagnosis
Pre-dispatch ref-audit exceptions were converted to generic strings. The dispatch
layer then treated an unreadable publication guarantee as a read-only contract
failure. The lower-level publication auditor also discarded Git stderr, so even
retaining its exception alone could not recover the actual cause. This matches
the issue's hypothesis and is a shared diagnostic failure.
Before implementation,
python3 -m unittest discover -s tests -p test_precheck_causes.pyexposed the missing Git stderr, missing configurationexception message, and a bare string returned on capture failure. The module now
exercises a real Git subprocess against a missing local remote as well as injected
failures and successful retries.
The invariant is that an unreadable ref audit supplies redacted evidence, retries
once, and stops before executor invocation with
publication_unverified.Related-work search covered the issue's references, open and closed precheck/ref
audit issues, and merged precheck PRs. #508 and #511 already cover socket-blocked
isolation probes. #458's dispatch-after-consent behavior remains separate. #450
and #274 supply the surrounding capability-parity context. This implements the
root diagnostic fix within #510's scope without closing other work.
Changes
cycle_journal.redact, including the publication auditor's Git/GitHub failures.publication_unverifiedwith
start_state=not_startedon persistent failure. Retain failed-attemptevidence after a successful retry and stage artifacts after a failed post-audit.
precheck diagnostics.
Exception/OSErrorhandler in the five dispatch files,classified by whether it can swallow, must report, or leaves verification
incomplete. A regression checks inventory coverage and handler counts.
dependency in the fast-path map. Update existing stop-result assertions to
require the new classification and cause without starting an executor.
The stop behavior was already owned by
docs/role-workspace-policy.md; this PRdocuments the retry and evidence fields there and adds the requested inventory
to
docs/capability-parity-audit.md. It adds no permission veto or dependency.Work units
Security review
cc-security-reviewran on the accumulated change. No confirmed vulnerabilitywas found. Reviewed surfaces: untrusted Git/GitHub stderr entering result artifacts
and reports, redaction before bounding, retry control flow, and dispatch prevention
when audit coverage is missing. No new shell interpolation or permissions are
introduced. Residual risk: journal redaction recognizes known credential formats
and is not proof that arbitrary provider diagnostics contain no sensitive data.
Live provider outages were injected; the Git nonzero-exit boundary ran locally.
Verification
Agent-reported results:
python3 -m unittest discover -s testspython3 scripts/validate-package.pypython3 -m unittestbasedpyrightpython3 -m unittest discover -s tests -p test_precheck_causes.pypython3 -m unittest discover -s tests -p test_fast_path.pypython3 -m unittest discover -s tests -p test_dispatch_failures.pypython3 -m unittest discover -s tests -p test_consent_variants.py -k test_rev016_bash_baseline_and_real_hook_allow_and_denyThe final full run completed in 476.983 seconds. Earlier full runs exposed an
intermediate Git-helper regression, missing test registrations and old result
assertions; those were corrected. Two consent-pattern time-budget errors passed
on isolated rerun and in the final full suite. The existing POSIX-permissions
test skipped in this environment. Full schema-2 check evidence is repeated in
the stage summary comment, including the earlier failed attempts.
The full suite runs with the project's existing test isolation;
the new boundary test uses a temporary local Git repository and needs no global
Git identity, credentials or network. CI states are reported separately for the
uploaded head under the parallel CI policy.