Skip to content

Lab tooling: the lab channel, Command File Runner, scripts and the console-iteration skill - #107

Open
dayfine wants to merge 180 commits into
mainfrom
lab/tooling
Open

dayfine wants to merge 180 commits into
mainfrom
lab/tooling

Conversation

@dayfine

@dayfine dayfine commented Nov 1, 2026 •

Copy link
Copy Markdown
Owner

Base: main (it was base/upstream-main, an older copy of upstream main that main contains), so the diff is the lab tooling alone. Running console automation from scripts needed to select a program, set its options, start and stop it, read its state, and press buttons or check detectors between runs, all without a window click; the lab control folder and the Command File Runner's inbox did parts of that and needed the right program selected and running. The lab channel is one folder per app, <profile>/Lab/: a request is inbox/<name>.txt, one command per line (select, set, start, stop, state, keepawake, owner, plus every Command File Runner command), its journal is outbox/<name>.out, and state says what the app is doing; the Command File Runner's command table runs behind it, the devtools/lab/ scripts (lablock.sh, labctl.sh, cfrun.sh) and the console-iteration skill speak it, and Lab.md is the one document for the files, the commands and a worked run. Tested with the unit tests (request, journal and state formats, the owner lock, the keep-awake schedule, command arguments), the fork CI (Ubuntu, Mac, Windows Clang) and dry runs of the scripts against a fake app serving the Lab folder; a console still has to verify select, set, start/stop, keepawake and the owner rule on a live app. Supersedes fork #105 and #106; #103 still brings the CFR to the fork's main.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

dayfine and others added 18 commits October 31, 2026 09:21
* Add Command File Runner, a developer program driven by text command files

Answering "does this detector fire on that screen?" meant a rebuild and a
full program run. Command File Runner runs .txt files dropped into
<folder>/inbox against the live console, one command per line (press,
dpad, stick, wait, shot/shots, detect, wait_for/expect, state, close_game,
help, stop), and writes a timed result file with screenshots to
<folder>/outbox, stopping a file at its first failing line.

Options set the command folder and whether to stop once the inbox is
empty. Games can register their own commands and detectors. README.md
next to the code documents the file format and every command; like the
other testing programs it has no page on the documentation site.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Command File Runner: unit tests for reading command files

Moves the line splitting, button and D-pad names and the inbox order into
their own file, unchanged, and tests them without a console.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Command File Runner: replace CommandLine with free functions

A command line is now just its words: split_command_line() returns them,
and required_arg(), optional_number() and optional_duration() read
arguments from them, with the same error messages. All definitions move
to the .cpp. Adds a unit test for the argument readers and checks the
error messages.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Command File Runner: read numbers with strtod() instead of std::stod()

On the macOS Intel CI build, the std::invalid_argument from std::stod()
escapes the catch (std::exception&), so the "argument errors" test failed
with "Unknown exception". strtod() reports a bad number without
throwing; the error message is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Command File Runner: walk until the screen holds still, and report how long it moved

A timed stick hold moves a different number of tiles from one try to the
next, so a map measured with holds is not measured. "walk x y" holds the
left stick in 200 ms slices and stops when two slices in a row barely
change the screen (a wall, a sign, someone in the way).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Command File Runner: 'history label' saves the console's recent video

With Stream History on, a lab script can keep the video of a program run
that just ended (the RNG reset and launch) by running this right after.
Ported from beceebc on lab/frlg-nav-cfr to the free-function command
signature.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
* Code health: skip nested and detail classes in the single-method interface check (#82)

A class nested in another class, or in a detail or anonymous namespace, is an
implementation detail such as a type-erasure base, not an interface others
implement. MoveOnlyFunction's private Callable base was flagged.


Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* Code health: lexical C++ style checks on added lines (#94)

* Code health: skip nested and detail classes in the single-method interface check

A class nested in another class, or in a detail or anonymous namespace, is an
implementation detail such as a type-erasure base, not an interface others
implement. MoveOnlyFunction's private Callable base was flagged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Code health: lexical C++ style checks on added lines

Check the lines a change adds for the upstream bans (std::filesystem,
std::thread, std::mutex, std::async), control-flow brace formatting, and
the Abseil tips adopted in the fork's C++ style notes: mutable globals
(#103), new/delete (#126), std::bind (#108), return std::move(local)
(#120), top-level const by-value header parameters (#109), bool
parameters (#94), header using-directives (#153) and forward
declarations. A comment that describes a neighbouring function is an
advisory.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* code_health: match functions to their base by name, not by signature (#95)

Changing a parameter's type (std::function to MoveOnlyFunction in #90) changed
the function's key, so an existing 133-line constructor was held to the new
limit of 50 instead of its base length. Functions now match on their qualified
name without parameters; messages still show the full signature.


Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* Settings: default audio display and collapsed console settings

Two global settings for people who run many programs on one lab machine:
"Default Audio Display" (Audio Pipeline group) is what a program's console
shows for its audio until that console's own setting is saved, so a new
panel no longer opens with the frequency bars; and "Start with console
settings collapsed" folds each program's "Console N Settings" box at
creation, so the video is at the top. Both default to today's behavior.

AudioOption takes its initial display type from the global setting
instead of a fixed FREQ_BARS; a panel's saved value still wins.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
(cherry picked from commit 92d1ed3c6f6fa0468827ab15c51ec3cc71f01d32)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
When <user files>/LabControl/ exists, the main window polls it every
500 ms. A "start" or "stop" file does what clicking Start/Stop Program
does and is then deleted; "state" holds the program state and the
selected program's identifier. Nothing changes when the folder is absent.

The button's handler moves into start_or_stop_program() so both paths
share it.

Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit f6f658f)
The folder, the start/stop files, the state file's lines and when the
error line appears were described only in LabControl.h's header and in
the lab scripts that use it. This says it next to the code, with the
shell sequence a script uses.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
(cherry picked from commit 953ae68)
Answering "does this detector fire on that screen?" or "how far does a
hold move?" meant a rebuild and a full program run. The Command File
Runner runs .txt files dropped into <folder>/inbox against the live
console, one command per line (press, dpad, stick, wait, walk until the
screen holds still, shot, shots, history, detect, wait_for, expect, state,
close_game, help, stop), and writes a timed result file with screenshots
to <folder>/outbox, stopping a file at its first failing line. Games can
register their own commands and detectors. README.md next to the code
documents the file format and every command; unit tests cover the
parsing. Squashed from fork lab/main (fork PRs #58, #84, #92).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…recipes

How a console automation segment goes from idea to three passes in a row:
define, code, observe, hypothesize, verify by hand with one CFR batch per
question, fix one thing, rerun; the Switch as an external machine, hard
stops, what to measure before fixing, and the CFR recipes (launch to a
save from HOME, count tiles by taps, find a wall, talk and answer prompts,
record a human walk, measure a threshold, recover). From the fork's
agents branch (fork PRs #96, #101). Under skills/ because .claude/ is
ignored in this repo.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…om the shell

Three portable sh scripts under devtools/lab that speak the app's two file
protocols: lablock.sh holds one console for one command (a "train") and
hands its token down, so a stray script from an old run cannot touch what
the current run drives; labctl.sh starts, stops and reads the selected
program through the Lab Control folder; cfrun.sh sends one Command File
Runner batch and prints its .out, stopping only the lab's own keep-awake
and refusing any other running program. The README explains the three,
the one-train rule, the folders they use, and the gap that stays out:
the app has no way to select a program from a script.

Tested without a console: sh -n on each, and dry runs against a fake app
that plays both folder protocols (lock nesting, refusal, waiting and
stale clearing; start/stop/state; a passing batch, a failing line, a busy
console, a wrong selected program, keep-awake and the select hook).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
The skill described the loop through one game's lab: checkpoint names,
run ids, map names, a traps section and the scripts of one lab folder.
Now it is the loop for any console automation segment, with each rule's
reason kept as one generic clause. The CFR recipes section is gone;
where the loop uses the Command File Runner or the Lab Control folder it
says so inline (read the state file to see what runs, one batch per
question, the lock, the HOME-tile check before a reload) and leaves the
command table to the CFR README and the folder protocol to LabControl.md.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
The lab channel will run the same commands from a worker thread with no
program running, so the runner's line runner is reachable through free
functions (run_command_file_line, command_file_command_kind, the error
screenshot and help) instead of living inside the program's loop. The
command session takes a console and a controller context rather than a
program environment. Splitting lines, finding the next inbox file and the
two journal lines move to CommonFramework/Windows/LabRequest, which the
channel shares; the journal's failure line is now "error <line> (...)".
Also ports the lab's "taps" command (D-pad taps, each measured against the
frame before it) with its argument parsing and test.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…lder

Scripts drove the app through two mechanisms: the LabControl/ folder for
start and stop, and the Command File Runner's inbox for presses and
detectors, which needed that program selected and running. The lab channel
is one folder, <profile>/Lab/, independent of the selected program. A
request is inbox/<name>.txt, one command per line, run in order from a
worker thread and moved to done/; its journal outbox/<name>.out has one
"ok"/"error" line per command and ends with "end"; "state" is rewritten
after every request and whenever the program state changes, with seq,
state, program and the last error.

Commands: start, stop, state, help, and every Command File Runner command.
Presses run only while no program runs; screenshots and detectors any
time. The window actions run on the UI thread through LabChannelHost; the
console commands come from a LabConsoleCommands implementation per console
type (SwitchLabCommands), wired in Main.cpp. A panel change cancels the
command running on the old panel before it is destroyed. LabControl is
removed; its tests move to the channel's, which cover the request and
journal formats and the state text.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
"select GAME:PROGRAM" shows that program as clicking it in the program list
does (ProgramSelect::select_program looks the identifier up across the
game lists, PanelListDescriptor exposes its entries for that), and the
request fails if the window did not switch. "set KEY JSON" sets one option
of the selected panel by its key in the settings file, live: the panel's
JSON is taken, the key (a dotted path for groups) replaced, and loaded
back without the ConsoleSetup section, which would reconnect the devices;
the journal prints the value the panel then holds, so a clamped or refused
value is visible. Both are refused while a program runs, and both run on
the UI thread.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Two scripts driving one console interleave their presses, and the lab ran
a Prevent Sleep program between runs just to keep the console awake.
"owner claim TOKEN" claims the channel; after that every request that
changes anything (select, set, start, stop, keepawake, presses) must start
with the line "owner TOKEN" or is refused naming the holder, while
state, help and the screen-reading commands stay open to all. "owner
release" with the token frees it; the lock lives in memory and dies with
the app. "keepawake on|off [seconds]" has the worker press B every N
seconds (default 15) while no program runs, through the console commands'
keep_awake(); a running program pauses it. "state" gains the owner line.
Tests cover the owner line of a request, the lock's rules and the
schedule.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Lab.md documents the channel in one place: turning it on, the request,
journal and state formats, every channel and console command with its
defaults, the detectors, the owner rule, a shell session that launches the
app on a profile, claims the channel, selects a program, sets two options,
starts it, waits for STOPPED and releases, with the request and the
journal it produces, and what remains of the Command File Runner program.
The runner's README keeps its program-specific parts and points at Lab.md
for the commands; LabControl.md says where the old folder went.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
labctl.sh sends one channel request per call and prints its journal:
state, start, stop, select ID, set KEY JSON, owner claim/release,
keepawake, and send NAME for any request from stdin; LAB_OWNER puts the
owner line first. cfrun.sh is the lock plus labctl.sh send: no program
has to be selected or started for a batch any more, and the Prevent Sleep
handling goes (keepawake replaces it), so the CFRUN_SELECT gap closes.
lablock.sh is unchanged. The README follows: the channel instead of the
two folders, a worked run of a program with nothing clicked, how to run a
lab app beside the live app (a second bundle id, open -n, --profile), and
probing between runs. The skill points at Lab.md. Dry-run against a fake
app serving the Lab folder: every command, a failing batch, the lock
refusal and the no-app timeouts behave as documented.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
@dayfine dayfine changed the title Lab tooling: lab control folder, Command File Runner, and the console-iteration skill Lab tooling: the lab channel, Command File Runner, scripts and the console-iteration skill Nov 1, 2026
The repo's C++ style asks for std::format where a message has several
parts, instead of "+" / std::to_string chains or an ostringstream. Converts
the journal lines, the argument errors, the screenshot labels, the walk
report's change list and the test messages in the runner and the lab
channel: 18 std::to_string sites and one ostringstream, with the same text
as before ({:f} keeps to_string's six decimals). The two ostringstreams
that collect a request's journal stay: they are the std::ostream the
commands print to, not a message.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
@dayfine
dayfine marked this pull request as ready for review November 1, 2026 05:20

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this file

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted in 842ef8b. Lab.md's "Changes from the lab control folder" section is the one place that says where the old folder went; nothing linked to this file.


MainWindow::MainWindow(QWidget* parent)
: QMainWindow(parent)
MainWindow::MainWindow(std::unique_ptr<LabConsoleCommands> lab_console)

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it ok to change QMainWindow/ main here?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed in 9c4b56f. The channel needs two things only the window has: the panel it shows now (and when that changes) and the program list to select by identifier, so some hook in MainWindow is unavoidable; the alternative, a public accessor for the current panel on PanelHolder, would widen an interface everything implements. The least intrusive form is what is there now: one private member, created by LabChannel::start_if_enabled() with two lambdas, plus the two set_panel() calls where the panel changes; the constructor signature and the public surface are back to upstream's. The call returns nullptr when <user files>/Lab/ does not exist at startup, so a normal app starts no thread and polls nothing.



MainWindow w;
MainWindow w(std::make_unique<NintendoSwitch::SwitchLabCommands>());

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this too intruding?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed; Main.cpp is back to upstream's in 9c4b56f (zero diff). The console-command object is made in MainWindow.cpp next to the channel, where PanelLists.h already pulls in every game, so no new layering is introduced there.

"see what happens", and never rerun to "confirm" something a hand batch can
show.

The tools this loop leans on, by path:

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to actually use this?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a "How to use" section in c23466d: where the skill lives and how it is installed (ln -s into ~/.claude/skills), when it loads, and the exact first commands (labctl.sh state, owner claim, select, set, start, a cfrun.sh batch, lablock.sh run), with Lab.md and devtools/lab/README.md as the references for the command table and the scripts' parameters.

Comment thread skills/console-iteration/SKILL.md Outdated

## 1. Define a segment, then code it

A segment is **one map, or one story event**, never both. A map boundary is

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still a bit too autostory-specific

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworded in c23466d: a "segment"/"checkpoint" is now "a step the screen can prove", the story layer is the game-event layer, the save rules ask what the program under test saves instead of assuming a checkpoint run that saves at its start, and the BDSP-only phrasing is gone. AutoStory remains only as the named example in the How-to-use command block.

@dayfine

dayfine commented Nov 1, 2026

Copy link
Copy Markdown
Owner Author

Review of 4151709e3: five correctness findings (two P1, three P2). Posted here because GitHub blocks a second review while the existing pending review is open; that pending review has been left untouched.

1. [P1] Wait for worker completion before destroying the channel

LabChannel.cpp:181

On Windows with Qt > 6.8.3, PA_ENABLE_QT_ADOPTION_WORKAROUND selects Thread_Qt.tpp, whose Thread::join() intentionally releases/leaks the QThread without waiting for run() to return. This destructor therefore does not establish that the worker has finished before its mutexes, condition variable, console, and other members are destroyed. A worker waking from m_idle_cv or returning from poll() can still access this object after destruction. The thread is started even when Lab/ does not exist, so this also affects ordinary app shutdown. Please use an application thread-pool task and wait for the task's actual completion before destroying the channel.

2. [P1] Do not reclaim a lock whose owner is still initializing it

lablock.sh:29

mkdir "$L" succeeds before the PID is written at line 57. During that interval a second caller's held() sees no PID, so clear_stale() deletes the first caller's live lock and allows another acquisition. Both callers then run their protected commands, and either exit trap can remove the other's lock. I reproduced this with the unchanged script, an isolated temporary LAB_DIR, and 20 concurrent callers: two workers were admitted and their protected work overlapped. Lock publication and stale-lock reclamation need to distinguish an initializing owner from a dead owner.

3. [P2] Keep screen-only requests independent of controller completion

NintendoSwitch_LabCommands.cpp:77

This unconditional wait also runs for READS_STREAM commands while a program is RUNNING. ControllerContext::wait_for_all_requests() waits on the shared controller's pending commands, including those issued by the program; LineRunner::current_frame() also waits before taking a snapshot. A long controller hold therefore delays a screenshot/detector request until the program's queue drains, although these commands are documented as available during a run. Since the channel processes requests serially, a subsequent stop request is blocked behind that read too. Please bypass controller queue waits for stream-only commands, including the wait inside current_frame().

4. [P2] Return a rejected start to the request journal

LabChannel.cpp:63

start_or_stop_program() returns void: it sends a start_program()/stop_program() error to UI listeners and discards the error string. Returning an empty string here therefore journals success even when start_program() rejected the start, for example when check_validity() fails. A multi-line request then continues with later commands while the program remains STOPPED. Please propagate the actual ProgramSession operation's error to the channel so the request stops and records an error line.

5. [P2] Preserve the JSON remainder instead of rebuilding it from words

LabChannel.cpp:114

split_command_line() tokenizes on whitespace without tracking JSON quoting, and this loop rejoins tokens with one space. A valid request such as set KEY "a b" silently becomes "a b". A string containing a space followed by #text is truncated by the tokenizer's comment handling and becomes invalid JSON. This prevents set KEY JSON from preserving arbitrary string option values. Please parse the command and key separately and pass the original remaining JSON text to parse_json(), with comment handling that respects quoted strings.

dayfine and others added 5 commits October 31, 2026 22:31
Lab.md's "Changes from the lab control folder" section already says where
the old folder went; a pointer file next to it is one more place to read.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
start_or_stop_program() reports the ProgramSession's error to the UI
listeners and returns nothing, so a start that check_validity() refused
was journaled as "ok" and the request went on with the program still
STOPPED. The channel now calls start_program()/stop_program() itself and
returns their error, which becomes the request's error line.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…text

The words of a line are split on spaces and cut at '#', so "set KEY
\"a  b\"" reached parse_json() as "a b" and a string with a space and a
'#' was cut into invalid JSON. strip_comment() now respects JSON quotes
(with '\' escapes) and the line's words are split after it; "set" takes
its value from the line itself, line_after_words(), with spaces and '#'
intact. Tests cover both, and "set KEY" without a value is an error.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Main.cpp is back to upstream's and MainWindow's public surface is
unchanged: the window keeps one private member, created by
LabChannel::start_if_enabled() with two callbacks (the current panel, and
select by identifier) and told of panel changes. The call returns nullptr
when "<user files>/Lab/" does not exist at startup, so an app without the
folder starts no worker and polls nothing; the folder is created before
launch (Lab.md, labctl.sh say so). The worker is a pool task whose
completion the destructor waits for, instead of a Thread, whose join()
does not wait under the Qt thread-adoption workaround and could leave the
worker touching a destroyed channel.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine and others added 30 commits November 16, 2026 02:29
Lab preflight: put the options back after a panel change
Lab: user hold on the console (app side)
…urce without a developer token

The lab has no developer token, so no lab profile could select the mGBA Link
entries. The environment opt-in keeps them hidden for everyone else.
make_controller() registered itself while holding m_state_lock. For a
connection that is already ready, add_status_listener() calls
post_connection_ready() at once, which takes m_state_lock again: the UI
thread spun forever. The mGBA Link connection is ready on construction,
so selecting a panel that uses it hung the app.
docs: design headless mode for SerialPrograms (--headless)
make_all_panel_lists() and find_panel(lists, id) replace PanelCatalog;
ProgramSelect keeps its lists, category map and add(). Drop the
unreachable null branch in load_panel_session() (holder now last) and the
JsonValue forward declaration. Tests: lookup past a divider and declined
intent skips load.
PanelCatalog: extract widget-free catalog and load_panel_session() (PR 1)
MgbaLink: lab opt-in without a developer token; fix controller-session self-deadlock
…lessProgramObserver

ProgramSession::Listener declares six pure virtuals; the observer overrode
only four, so Windows Clang rejected it as an abstract final class.
HeadlessHost: add --headless --run one-shot runner (PR 2)
…tooling

# Conflicts:
#	SerialPrograms/Source/CommonFramework/Main.cpp
#	SerialPrograms/Source/CommonFramework/Windows/Lab.md
#	SerialPrograms/Source/CommonFramework/Windows/LabChannel.cpp
#	SerialPrograms/Source/CommonFramework/Windows/LabChannel.h
#	SerialPrograms/Source/CommonFramework/Windows/LabChannel_Tests.cpp
#	SerialPrograms/Source/CommonFramework/Windows/LabRequest.cpp
#	SerialPrograms/Source/CommonFramework/Windows/LabRequest.h
#	SerialPrograms/Source/ComputerPrograms/ComputerPrograms_UnitTestRunner.cpp
#	SerialPrograms/Source/ComputerPrograms/ComputerPrograms_UnitTestRunner.h
#	SerialPrograms/Source/NintendoSwitch/Programs/CommandFileRunner/NintendoSwitch_LabCommands.cpp
#	SerialPrograms/Source/NintendoSwitch/Programs/CommandFileRunner/NintendoSwitch_LabCommands.h
#	SerialPrograms/Source/Tests/CommandLineTests.cpp
LabHold_Tests & LabProgramContract_Tests: fix -Wmissing-designated-field-initializers
Merge lab/main into lab/tooling (Headless CC + PanelCatalog + StartupArguments)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

game:shared Shared or game-neutral code lab-tooling Lab channel, CFR, scripts, run records, build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants