Skip to content

BBQ Farmer: log and capture each attempt to reach a catch, Sneak Up or photo target - #19

Closed
dayfine wants to merge 7 commits into
bbq/tests-filefrom
bbq/target-diagnostics
Closed

dayfine wants to merge 7 commits into
bbq/tests-filefrom
bbq/target-diagnostics

Conversation

@dayfine

@dayfine dayfine commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Depends on #51 (PokemonAutomation#1754, the BBQ tests file). Base: bbq/tests-file; the diff shows only this change.

Part of PokemonAutomation/ComputerControl#263.

On a lab run, Catch Any and Sneak Up spent 48% of an hour failing to find a target, and the log only said Did not enter battle. Did target spawn?. This logs a checkpoint after lock-on, before the shutter and on a timeout, then each attempt's outcome from what the detectors reported, so a missing target can be told apart from a missed arrival or a missed detection; with the new "Save Target Diagnostics" option (off by default) it also saves the checkpoint frames and, on a possible miss, the stream history under DebugDumps/BBQ/targets/, after the attempt ends. No controller command, wait or decision changes. Seven PokemonSV::BBQTargetAttempt tests in PokemonSV_BBQTests.cpp cover the outcome, the history decision and the log line; the native BBQ runner passes 17 of 17, and it has not run on a Switch yet. Fork #3 also saves a frame at the catch battle-entry timeout, so whichever lands second should keep only one of the two captures.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

dayfine and others added 2 commits October 27, 2026 22:59
PokemonSV_Tests.cpp registers every SV test, and each BBQ change adds
its controller tests there, so parallel BBQ changes all conflict in it.
Move the Tera encounter tests unchanged into
Programs/Farming/PokemonSV_BBQTests.cpp, registered through one
add_tests_BBQ() call, following the add_tests_<Module>() pattern the
detectors use.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
… target

Catch Any and Sneak Up spent 48% of an hour failing to find a target, and
the log only says "Did not enter battle. Did target spawn?". Record each
attempt so a run can tell a missing target from a missed arrival or a
missed detection:

- log a checkpoint after lock-on / before the shutter, and on a timeout,
  then the attempt's outcome from what the detectors reported;
- with the new "Save Target Diagnostics" option (off by default), save the
  checkpoint frames, and the stream history on a possible miss, under
  DebugDumps/BBQ/targets/, after the attempt ends.

No controller command, wait or decision changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
@dayfine
dayfine force-pushed the bbq/target-diagnostics branch from b285ce8 to 6d37467 Compare October 28, 2026 08:08
@dayfine
dayfine changed the base branch from main to bbq/tests-file October 28, 2026 08:09
@dayfine
dayfine force-pushed the bbq/tests-file branch 2 times, most recently from bf82b48 to daa1de3 Compare October 28, 2026 20:37
@dayfine dayfine added farmer Farming programs game:sv Scarlet/Violet labels Nov 1, 2026
@dayfine

dayfine commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

Superseded by consolidated Tree 4 PR #275.

@dayfine dayfine closed this Nov 9, 2026
@dayfine
dayfine deleted the bbq/target-diagnostics branch November 13, 2026 03:26
dayfine added a commit that referenced this pull request Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

farmer Farming programs game:sv Scarlet/Violet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant