Skip to content

FRLG AutoStory stage 2: player name, SID Helper and Starter RNG - #214

Closed
dayfine wants to merge 60 commits into
frlg/stage1-corefrom
frlg/stage2-rng
Closed

dayfine wants to merge 60 commits into
frlg/stage1-corefrom
frlg/stage2-rng

Conversation

@dayfine

@dayfine dayfine commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

Depends on #213

FRLG AutoStory stage 2: typing the player name, stopping for SID Helper, planning Starter RNG attempts from its candidates and running Starter RNG in the program. It started as one squashed commit of frlg/autostory-rng-loop and replaces #177, #178, #179, #182, #183, #184 and the PR-less frlg/rng-plan-base, which carries earlier versions of #181, #185, #186, #187 and #188 (those stay open). It will be split again for upstream.

🤖 Generated with Claude Code

https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

Squash of fork PRs #177, #178, #179, #182, #183, #184 and frlg/rng-plan-base (frlg/autostory-rng-loop at 07819f4).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine and others added 14 commits November 7, 2026 07:00
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

# Conflicts:
#	SerialPrograms/Source/VideoGames/PokemonFRLG/PokemonFRLG_Tests.cpp
# Conflicts:
#	SerialPrograms/Source/VideoGames/PokemonFRLG/PokemonFRLG_Tests.cpp
#	SerialPrograms/Source/VideoGames/PokemonFRLG/Programs/AutoStory/PokemonFRLG_AutoStoryEvents.cpp
#	SerialPrograms/Source/VideoGames/PokemonFRLG/Programs/AutoStory/PokemonFRLG_AutoStoryEvents.h
# Conflicts:
#	SerialPrograms/Source/VideoGames/PokemonFRLG/PokemonFRLG_Tests.cpp
# Conflicts:
#	SerialPrograms/Source/VideoGames/PokemonFRLG/Programs/AutoStory/PokemonFRLG_AutoStory.cpp
#	SerialPrograms/Source/VideoGames/PokemonFRLG/Programs/AutoStory/PokemonFRLG_AutoStory.h
The merge's parity test passed: every StoryData file, 00.01b and the
00.04/00.04b split included, loads to its C++ row. The rows and the test go.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine and others added 2 commits November 10, 2026 10:05
FRLG AutoStory stage 2: 00.01b and the 00.04 split as JSON
…eckpoints "phase": "testing"

Stage 1's files and reader now carry "metadata"; stage 2's own files,
00.01b and 00.04b, get "metadata": {"phase": "testing"} too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine and others added 23 commits November 10, 2026 11:41
FRLG AutoStory: mark stage 2's checkpoints phase testing
…g/stage2-rng

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…stage2-rng

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
… headers

Code health on the stage's own code: names and key text as std::string_view,
the naming keyboard header split into keys, cursor and planner, the RNG
headers split by concern (Method 1, Starter RNG timings, target, outcome,
loop log), and the naming screen tests moved into their own file.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…nto frlg/stage2-rng

00.04 keeps the stage's version (it hands off to Starter RNG); the rival
battle now in 00.04b names TRAINER_RIVAL_OAKS_LAB_BULBASAUR and its
Bulbasaur, as #213's plans do.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
# Conflicts:
#	SerialPrograms/Source/VideoGames/PokemonFRLG/Programs/AutoStory/PokemonFRLG_AutoStory.cpp
#	SerialPrograms/Source/VideoGames/PokemonFRLG/Programs/AutoStory/PokemonFRLG_AutoStoryEvents.cpp
…heck

Each case runs check_party_free_slots() with the real slot detector on a
party menu screenshot, replacing the scripted PartyCheck cases and the
separate LastOccupiedPartySlot test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…tion#1896

Upstream removed scripted navigation behavior tests (PokemonAutomation#1896). Follow it:
take its Navigation and Tests files, drop PartyCheckActions, the image
overload of detect_last_occupied_party_slot and the party check tests,
and run the check directly in start_program_game_checks().

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…itchProgram hook

Drop the start_program_game_checks() hook from SingleSwitchProgramInstance.
Each RNG program calls check_free_party_slots() first in program().

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…ty slots check) into frlg/stage2-rng

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
PokemonFRLG_Tests.cpp: take upstream PokemonAutomation#1896's removal of the exit_wild_battle tests; keep this branch's tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
@dayfine

dayfine commented Nov 18, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #652: every commit of this PR is in it; the engine review fixes merged here go with the shared core #648.

@dayfine dayfine closed this Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant