Repository navigation
Conversation
FRLG's loop also ends where the user takes over (target hit but not shiny, attempts spent); that is a stop with a message, not an error. A shiny is a continuation whose rows the game builds, so the seam carries no rows. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Folded leaf PR #445; tree equals the leaf tip. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Folded leaf PR #329; tree equals the leaf tip. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…ange-options Folded leaf PR #320; tree equals the leaf tip. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…tion, engine) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…kpoints (set_pause_points) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
An empty or dropped frame has count 0 and zero stats, which level_of() read as uniform and dark, so it could start or extend a black fade and give a false FADE_BLACK warp. push() now skips such samples. Tests mix empty frames into a scene and into a rise. Also: named bool args, optional beat in the talk-over test, no issue numbers in comments. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
SourceFiles.cmake and Pokemon_AutoStory_Tests.h: keep both sides' lists. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…ay and notification text Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…emonAutomation#1894) Prevent an OCR misread from making a non-boss as boss during boss battle. - Leave the boss empty in header read if not GlobalState::opponent_fits_stage() in process_header_read - Retry the OCR in summary read, which makes a valid boss string more likely - accept_opponent() then only records a valid boss - boss_if_caught() returns the boss only after the fourth win - If the boss is still empty, throw (same as before) Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…ions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Pokemon Navigation: shared fault sweep runner, seeded rows and known-failing list
…dopt # Conflicts: # SerialPrograms/Source/ComputerPrograms/ComputerPrograms_UnitTestRunner.cpp # SerialPrograms/cmake/SourceFiles.cmake # devtools/maps/tests/test_leg_trace.py
…nner The fault sweeps build SweepVariants for Pokemon::run_sweep() under sweep_clean_first(); both known-failing lists are Pokemon::KnownFailing, with a new test that each SimFailureCases entry names a case; the wanderer rows run on run_seeds() (8 seeds, as before). Case names move out of the inputs; test names and the known-failing entries (0 sweeps, 3 cases) are unchanged.
run_settle() is one settle loop over TalkOver for every game, with the rule for each SettleKind (talk, after a warp, door) in one table. The door rule (1 s of the player still, 2.5 s calm, a look every 200 ms) comes from the BDSP tree as TalkOverRule's quiet and still fields and the PLAYER_STILL screen event. run_center_visit() is the shared order of a Center visit: in, settle, check inside, heal, out, settle (door or after warp), check outside. Games give the walks, reads and nurse through CenterVisitIO.
Door times private to the settle table, SettleEnd::Result nested, the IO last in run_settle() and the visit functions.
…sp/seam5-adopt # Conflicts: # SerialPrograms/Source/CommonTools/ScreenEvents/ScreenEventTypes.h # SerialPrograms/Source/CommonTools/ScreenEvents/ScreenEvents.cpp # SerialPrograms/Source/Pokemon/AutoStory/Pokemon_SceneJudges.cpp # SerialPrograms/Source/Pokemon/AutoStory/Pokemon_SceneJudges.h
talk_over() and StoryStepIO::settle run Pokemon::run_settle with settle_rule(kind); BDSP's SettleKind and TalkOverRule::door give way to the shared ones. ConsoleStory::heal and the sim's heal run Pokemon::run_center_visit through BdspCenterVisit (enter_lit_door, talk_to_nurse, run_into_door; pokemon_center_inside or indoors() as place()). The sim's play_scene runs the same loop. New sim cases for a slow Center fade-in, late fades and a run out that stays inside (heal_exit); fault sweep LATE_FADE and SLOW_FADE_IN on Center visits.
…or watching games
…the policy asks BDSP's title plays an attract movie, a town with people walking, that reads as the overworld; on console B (2026-11-15 03:42) the launch settled on it before the title took a press. A policy with overworld_after_load answers such a look with the title press and counts the overworld only after a title press and then the load's black.
Console B, 2026-11-15 04:21 (BDSP, Japanese): ZL on the title's attract movie went back to the title through a black, and that black counted as the load; the title, read as the overworld, then settled. With overworld_after_load, a press on an overworld look no longer arms the load, and a title showing again clears a black seen before it.
Console B, 2026-11-15 04:21, the game in Japanese: the launch never read the title (its check, a quiet screen, never held: the title shows PLAYER_CAN_MOVE) and settled on it. title_screen_shown() reads the red line under the logo and the starfield's dark bottom corners, which every language shares; the launch look carries it as TITLE_READING, and the policy turns on overworld_after_load so the boot's logos and the attract movie take ZL without counting as the overworld.
The old pin 7d108a25 lacked upstream FRLG FrontSprites, FrontSpritesShiny and PokeballSprites, so 72 FRLG sprite-reader tests failed with "Unable to open file". b4d7d425 merges PokemonAutomation/Packages master into the BDSP option-template branch.
make_UNIT_TESTS_ALL() passed the code-health function length limit (50 lines) once the SimSweep, SimSeeds and KnownFailing suites were added.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
added a commit
that referenced
this pull request
Nov 17, 2026
Conflict in PokemonBDSP_AutoStory_Walk_Tests.cpp includes: drop the duplicate Utils/Walk.h include, as #375 resolved it.
dayfine
changed the base branch from
bdsp/seam4-adopt
to
bdsp/center-run-settle
November 17, 2026 16:50
This was referenced Nov 17, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #375 (base
bdsp/center-run-settle); folds in #353 (story engine) and #523 (seam-4 fault sweeps), and has #546 merged in, so the diff shows the story engine, seams 4 and 5 and this change.BDSP AutoStory moves onto seam 5's shared settle loop and Center visit (#546's adoption list, step-5 design note decisions 1-6).
talk_over()is aSettleIOover the console (observer, B/next presses, wild-battle flee) and callsrun_settle;TalkOverSpec::rulebecomessettle(aSettleRule).StoryStepIO::settlepassessettle_rule(kind). BDSP'sSettleKindandTalkOverRule::doorare gone: the merge took AutoStory: shared settle loop and Pokemon Center visit #546'sSceneJudges/ScreenEvents, and the door timings (1 s / 2.5 s, 200 ms looks) are now the shared table's.run_into_center/CenterEntrygive way toBdspCenterVisit : CenterVisitIO(runs north in and south out on theStoryStepIO, its settle).ConsoleStory::healrunsrun_center_visitwith a console subclass: route turn before each run,enter_lit_doorlineup,talk_to_nurse+ B through her last line,place()=pokemon_center_insideorindoors()(the old exit check's room read). A failed check now returnsheal_enter/heal_exitinstead of throwing.play_scenerunsrun_settleon a scripted clock;SimExecutor::healruns the same visit (SimCenterVisit), the nurse not played;SimCenterDoorsknobs per heal step (slow fade-in played through the door settle, late fades, a run out that stays inside).Testing
Console failure on the simcases: 00.04b with a 4 s Center fade-in, with late fades at both doors, and with the run out stopping inside (r143a, must failheal_exit; red before, as the sim never walked out).late fades at a Pokemon Center's doorsclass per row;slow fade-in after every warpnow also plays a 4 s Center fade-in on every heal step. Known-failing lists unchanged.