Repository navigation
Conversation
dayfine
left a comment
There was a problem hiding this comment.
Reviewed SHA: 41acfbe
Verdict
NEEDS_REWORK
Small and mostly fine; logging is bounded (report_blink_progress runs only after the fresh check, so it fires once per new blink, not per loop pass). Read from the diff only, no build (CI green). Findings:
PokemonBDSP_BlinkRecovery.cpplog_calibration_progress:events % 5 <= 1logs at 5, 6, 10, 11, ... (two lines per five rolls) andevents == 1is redundant with it. Intended is one line per 5. Useevents % 5 == 0.- Same file, report_blink_progress: no log between
min_rolls_to_tryand the first candidate. That is the longest silent stretch (still searching, nohave_candidate), which is what the PR sets out to remove. Log a "searching" line there, throttled the same way. - Same file, the confirm branch logs on every fresh event. Bounded by
confirmation_events, but say so in the comment, or throttle like the calibration phase. display.set_progressmoved from every loop pass to afterif (!fresh) continue. That is a behaviour change to the option display, not logging. Keep it where it was (call it before thefreshcheck) or say in the description that it is intentional.PokemonBDSP_StarterRngAttempts.cpplog_target_wait: the text hard-codes "re-anchoring every 30s", a third copy of the 30 s (the other two areBlinkRecoveryConfig::reanchor_intervaland the literal30s,at ~line 603). Pass the interval in and format it, so the message cannot drift from the code.- Same file, log_blind_timeline: three adjacent
doubleseconds parameters (starly/select/confirm) are easy to swap at the call site, and the call passes 5 positional values without/*param=*/comments. Passschedule(or a small struct) instead of unpacking it. Durations are rawdoubleseconds here;Seconds/Millisecondsper the repo rule if the schedule fields allow it. - The two new messages "Checking the battle animation, then reporting the target hit or signed advance miss." and "Blind timeline finished; verifying the obtained starter." say the same thing twice in a row, and the first narrates code rather than state. Drop one.
- Description: not a symptom patch, but no shared logging rule either. If other Starter RNG phases need the same sparse milestone logging, a single helper in BlinkRecovery.cpp is better than per-site functions; fine to leave for later.
dayfine
left a comment
There was a problem hiding this comment.
Reviewed SHA: 41acfbe
Verdict
NEEDS_REWORK
Re-check at 2026-11-16 16:10Z: no rework has been pushed. The branch head bdsp/starter-rng-progress-logging is still 41acfbe, the SHA reviewed at 07:58Z (last commit 01:52Z). None of findings 1-8 in the earlier review are addressed yet. That review stands as the rework list:
events % 5 <= 1logs twice per five; use== 0and drop the redundantevents == 1.- Log a throttled "searching" line between
min_rolls_to_tryand the first candidate. - Confirm-branch logging: throttle it, or comment that
confirmation_eventsbounds it. - Keep
display.set_progressbefore thefreshcheck, or explain the change in the description. - Don't hard-code "every 30s"; format
reanchor_intervalinto the message. log_blind_timeline: passschedule(or a struct) instead of 5 positional values; useSeconds/Milliseconds.- Drop one of the two back-to-back verification messages.
- (Optional) one shared sparse-progress helper.
|
Addressed the review in
One point I left unchanged: the Code health: 0 failures. Fork Draft CI is green at |
dayfine
left a comment
There was a problem hiding this comment.
Reviewed SHA: 4746a53
Verdict
APPROVED
Re-review of the delta since 41acfbe (bcf6d4d, 4746a53), from the diff and the loop in context. No build of my own; Fork Draft CI and Code Health green, local code health 0 failures (only file-length advisories).
Earlier findings:
- Modulo double-log: fixed. Calibration now logs at 1 and every 5th roll, once each.
- Silent stretch before the first candidate: fixed.
search_updatescounts fresh events onceevents >= min_rolls_to_try, so "Still searching" keeps coming every 5 fresh rolls even when the retained window stops growing. That was the right counter to use. - Confirm-phase logging: the comment now says
confirmation_eventsbounds it. Fine. display.set_progress: back on every pass, before thefreshfilter, same as on the base branch.- Re-anchor text: formatted from
reanchor_interval. I accept the reply that the30sgiven todetect_shiny_battle()is a separate timeout. log_blind_timelinetakesPressSchedule. The fields are stilldouble, but that's the schedule's own type and out of scope here.- Duplicate verification message removed.
- Separate per-phase helpers: accepted.
Nits, non-blocking:
report_fresh_progressonly doessearch_updates += cond ? 1 : 0, then forwards six arguments and hands the counter back by return. Increment it inline beforereport_blink_progress(if (!have_candidate && events >= config.min_rolls_to_try){ search_updates++; }) and drop the wrapper. If the wrapper stays, give it a one-line comment like its siblings have.- The base branch logged "N rolls seen, no solution yet." on every failed solve. This PR removes it and "Still searching" replaces it. That's a reasonable trade (it was per-roll spam), but it changes the log, so mention it in the PR description.
…gging Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Stacked on fork PR #526 (
bdsp/starter-rng-adopt); this diff shows only live Starter RNG progress logging.The lake observation and target wait can remain quiet for minutes, making healthy work look stalled in both the log file and in-app log overlay.
This change logs:
Existing signed early/late advance reporting remains unchanged.
Tests:
origin/bdsp/starter-rng-adopt: 0 failures