Repository navigation
Conversation
dayfine
left a comment
There was a problem hiding this comment.
Reviewed SHA: 759f188
Verdict
APPROVED
Correctness: the fix is right and does not loosen the overwrite guard. 00.03's own plan starts at VerityLakefront (bdsp-00.03.plan.json, start/first step map), and 00.02 already says saves_in: "Verity Lakefront". With Run Starter RNG on, 00.02 ends at the Lakefront, so 00.03's start save (ConsoleStory::save, SAVES_IN_ARG) was comparing the card against "Twinleaf Town" and stopping the run. The check itself (save_game(..., *map) throwing FatalProgramException when the card names another map) is untouched; only the declared contract changed, and it now matches where the row really starts. Test: the extended test_run_starter_rng_in_story asserts save in 00.03 once and card for 00.03: Verity Lakefront. That is behaviour a caller relies on and it would fail on the old data. No raw ints, braces and CRLF are fine. Fork Draft CI green.
Non-blocking:
bdsp-00.03.plan.jsonhasformat: pokesim-authored-checkpoint/1, i.e. it is authored in PokemonSimulation. Confirm the source there has the samesaves_in, or the next sync overwrites this back to Twinleaf Town. Say which in the PR description.- Systematic check, not done in this PR: any row whose first step map differs from its
saves_inhas the same bug. A table test "row.saves_in == map of the row's start pose" over all rows would catch the class (StoryData_Tests.cpp already walks the table for saves_in). Worth a follow-up, not a blocker. StorySimulation_Tests.cppcomment "Console B, 2026-11-15:" is a log entry; the expectation already says it. Trim to what the test guards.
|
Applied the non-blocking comment trim in I also checked the PokemonSimulation checkout, all refs, and file history. There is no BDSP Agreed that a table-wide |
…-fix Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Stacked on fork PR #526 (
bdsp/starter-rng-adopt); this diff is the 00.02-to-00.03 checkpoint-save correction only.Console B on 2026-11-15 completed Starter RNG and returned at Verity Lakefront, then 00.03 refused to save because its card contract incorrectly expected Twinleaf Town. The refusal protected the shiny save from being overwritten.
The first commit adds the integration regression assertion and intentionally fails with the old Twinleaf Town card. The follow-up corrects only the authored
saves_incontract; the overwrite guard is unchanged.Tests:
card for 00.03: Twinleaf Townorigin/bdsp/starter-rng-adopt: 0 failures23defeb7d: passed (Ubuntu GCC build and unit tests)