Repository navigation
code health: rules for systematic fixes (learned rule needs a test, no special cases by name, plan lint) - #612
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
agents. Independent; the diff shows only this change.Adds the three rules the user approved as blocking code-health checks: a comment citing a console B finding needs a test or ConsoleFailures replay that cites the same date (and checkpoint), and removing the last such test fails; AutoStory C++ may not compare or look up checkpoint ids or plan event ids; a new or edited
legsevent in any game's plan needs "not planned: " in its why. Each is incremental against the base, and the two C++ rules take a justifiedcode-health: allowtag at the site.Self-tests: 172 pass (17 new in
test_systematic.py). On the diffs of #599, #604 and #610 the rules report nothing; on the commit that first added 17.03's hand-written legs (0bfb41f) plan lint reports exactly its four legs events. Whole-tree numbers and the limits of the date match are in the README's new "Systematic fixes" section.