Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Code Health's test-case rule wants each UnitTest built from one case struct of name, input and expectation, with the name outside the input. Move every case's name from its Input to the case itself, nest the RngHandoff input and expectation structs, and give the first-save, captured-transition and move-mechanics cases explicit names (the same test names as before). Assertions and test bodies are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
An Outcome may carry its StoryFailureClass (outcome_failed's third argument, for a game's own failure names); failure_class_of() falls back to the shared list's class for the name. The engine's failure lines ([Event], [Checkpoint], [Step], [Segment], [Verify]) end with "(class=<id>)" when the class is known, and an OperationFailedException that leaves an event is logged as class=operation_failed. Pokemon_StoryFaultSweep: a game gives its sweep as data (rows, an injector per sim fault, the known-failing list); the engine makes one test per class and row, named "<row>, <class id>", judges it, and checks the known-failing list names only its tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…/fault-classes # Conflicts: # SerialPrograms/Source/Pokemon/AutoStory/Engine/Pokemon_StoryEngine_Tests.cpp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
… run The shared wire cases at PokemonSimulation 866613f (and its main) still use the old pose (certainty/where) and per-kind step fields; since the #312 review the native reader reads steps as an action plus typed args, so every kind case without args failed. The Python reader still checks those cases; the native codec is covered by its own CTest cases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…onformance run Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…st-case) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
… on #312, ScreenEvents case names Conflicts: ScreenEvents_Tests.cpp takes #313's case struct (name outside the input); the story-data README keeps this branch's reader-only text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…eview) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…known (#312 review) checkpoint_end_pose() stopped looking back only at LEGS, so a STEP after a route kept the route's target as the end and the tile check failed a run that worked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
… step Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…and #313 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
AutoStory: story step types and engine (split from #122, layer 1 of 3). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
CommonTools: screen events for autonomous programs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…merged, review fixes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…rged, review fixes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
AutoStory: one story engine over a backend, save mode from checkpoint metadata.
FRLG's steps fail through frlg_failed(), which puts the class from FRLG's one failure table (frlg_failure_class(): own names, prefixed families, then the engine's names) on the Outcome, so the engine's failure line ends "(class=<id>)" as BDSP's and PLZA's do. All 73 sites move: step runner and events, walker and replay executor, battles, talk and healing, Mart, abilities and field moves, captures, slopes, boulders, the Rocket Hideout, launch/reload, and the row sim. The row sim names a failure the shared list has no class for "unclassified failure <name>", and a fault sweep with one fails even when it is on KNOWN_FAILING.
…m; Events.cpp under its line limit
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #614 (base
frlg/celadon-restock; also mergesautostory/fault-classes, #479, which brings nav/shared #332/#477, so the diff shows that merge too).FRLG had a table mapping its failure names to the shared story failure classes, but only used it to tag log lines; its steps still failed with plain
outcome_failed(), so the engine's failure lines carried no class the way BDSP's and PLZA's do. Now every FRLG step fails throughfrlg_failed(), which puts the class from that one table on the Outcome. All 73 sites move (step runner and events, walker and replay executor, battles, talk and healing, Mart, abilities and field moves, captures, slopes, boulders, Rocket Hideout, launch/reload, row sim). The row sim names a failure with no class "unclassified failure ", and the FRLG fault sweep fails such a cell even when it is on KNOWN_FAILING, so a new unmapped name shows up in CI.The merge's conflicts were test tables only (case names move outside the input, as the merged structs have them). Tested: touched files and all merge-affected files syntax-checked locally; new Failure outcome cases in the FRLG failure-class tests; full build and tests on Fork Draft CI.