Repository navigation
PLZA: promote unverified autosave rows from run logs - #624
Merged
Merged
Conversation
Reads SerialPrograms.log files for the autosave badge per checkpoint run and lists the unverified plan rows a passed run saw autosaving in their last step. --apply rewrites those rows to "save": "autosave" with autosave_step and cites the log in their source text. A badge before the last step, in a failed run, or a passed run without one leaves the row unverified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
plza/port-original-0308-0311(#623); the diff shows only this change.Ten PLZA plan rows (01.01-01.03, 02.01-02.05, 02.07, 03.01) are
"save": "unverified"because no run log had shown their autosave. This addspython3 -m devtools.plza_autosaves <logs...>: it reads SerialPrograms.log files (PLZA AutoStory programs only), finds the autosave badge per checkpoint run ([PLZA] autosave badge at <s>s in <step>, the older[Autosave] <id>/<n> <step>, and[Save] <id>: the game autosaved (seen)when the last sighting was a badge, not a menu save), and lists which unverified rows a passed run saw autosaving in their last step. With--applyit rewrites those rows to"save": "autosave"plusautosave_step, keeping each file's line endings, and replaces the "Save unverified: ..." sentence in the row's source with a citation of the log time. Tested with its unit tests (python3 -m unittest discover -s devtools/plza_autosaves/tests -t .).What a log cannot prove: a row is promoted only when a run of it passed and badged in its last step, and no other passed run of it lacked the badge, because a badge in a failed run or an earlier step says nothing about where the row ends. A missing badge is weak evidence too: the detector can miss the badge in dropped frames, and builds between 2026-11-14 22:17 and 2026-11-16 01:02 seem to have logged no sightings at all, so their "none" may be a logging gap. A badge also does not show that a reload lands at the next checkpoint's start, and the log names steps, not plan versions, so a renamed or re-split row needs a fresh run. Dry run on the lab-B logs (2026-11-11 to 2026-11-16): nothing promoted; 03.01 has one passed run with the badge at lobby_scene (2026-11-13 14:28) and two later passed runs without one (2026-11-15 23:43, 2026-11-16 00:57), so it stays unverified for a console run to decide.