Repository navigation
PLZA AutoStory: developer option to skip forced reloads - #625
Merged
Merged
Conversation
A chained run with "Developer: skip forced reloads" on goes on from the live screen into a row marked reload_when_chained "always" and logs "[Checkpoint] <id>: reload skipped (developer option)". Default off. run_plza_segments() takes SegmentRunOptions (attempts per checkpoint and the forced-reload switch); RewindPlan carries them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #623 (base
plza/port-original-0308-0311; the diff shows only this change).A chained PLZA run always reloads the start save of a row marked
reload_when_chained: "always"(03.04, 03.11), so there was no way to find out whether that reload is actually needed. This adds a developer checkbox, "Developer: skip forced reloads", to the AutoStory panel: with it on, a chained run goes on from the live screen into such a row and logs[Checkpoint] <id>: reload skipped (developer option). Default is off, so normal runs are unchanged. The reload after a failed start check is not affected. To fit the parameter limit,run_plza_segments()now takes aSegmentRunOptions(attempts per checkpoint plus the switch), whichRewindPlancarries.What to expect on console: 03.11 should still need its reload, since its
to_mablelegs are measured from the reloaded 3F spot; 03.04 is the open question this switch is meant to answer.Tested with two new cases in the
PokemonLZA::AutoStoryGame chainsuite (autosave seen and not seen: no reload, the line is logged); the touched files compile locally and code health reports 0 failures. No console run.