Skip to content

PLZA AutoStory: choice arrow box covers French's wider panel - #628

Merged
dayfine merged 1 commit into
plza/port-original-0308-0311from
plza/choice-box-wide
Nov 17, 2026
Merged

dayfine merged 1 commit into
plza/port-original-0308-0311from
plza/choice-box-wide

Conversation

@dayfine

@dayfine dayfine commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Depends on #623 (base plza/port-original-0308-0311; the diff shows only this change).

Run 11 (a new game in French) stuck at 01.02: the choice panel grows left to fit its longest row, French's starts at x 1198 and its arrow sits at x 1185, left of the arrow box's x 1256, so CHOICE_BOX never fired. The box now starts at x 960, room for rows about half again as long as French's. The rows reader already finds the highlight's left end by scanning, so it needed no change. Tested with the French frame added to the console-frame suite (CommandLineTests branch plza/choice-fr, CI pin bumped); the Italian, Japanese and Chinese frames stay in it.

French's 01.02 choice panel starts at x 1198 and its arrow at x 1185, left
of the box's x 1256, so CHOICE_BOX never fired (run 11). The box now starts
at x 960. The rows reader already scans the highlight's left end; the French
frame checks both. CI's CommandLineTests pin moves to plza/choice-fr.
@dayfine
dayfine marked this pull request as ready for review November 17, 2026 06:45
@dayfine
dayfine merged commit 708ba2f into plza/port-original-0308-0311 Nov 17, 2026
10 checks passed
@dayfine
dayfine deleted the plza/choice-box-wide branch November 17, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant