Repository navigation
PLZA AutoStory: choice arrow box covers French's wider panel - #628
Merged
Merged
Conversation
French's 01.02 choice panel starts at x 1198 and its arrow at x 1185, left of the box's x 1256, so CHOICE_BOX never fired (run 11). The box now starts at x 960. The rows reader already scans the highlight's left end; the French frame checks both. CI's CommandLineTests pin moves to plza/choice-fr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #623 (base plza/port-original-0308-0311; the diff shows only this change).
Run 11 (a new game in French) stuck at 01.02: the choice panel grows left to fit its longest row, French's starts at x 1198 and its arrow sits at x 1185, left of the arrow box's x 1256, so CHOICE_BOX never fired. The box now starts at x 960, room for rows about half again as long as French's. The rows reader already finds the highlight's left end by scanning, so it needed no change. Tested with the French frame added to the console-frame suite (CommandLineTests branch plza/choice-fr, CI pin bumped); the Italian, Japanese and Chinese frames stay in it.