Repository navigation
Conversation
- walk "end_after_ms": the end event seen before this much of the last leg is passed on the way, not taken. Run 14 (German, 02.05, console B 2026-11-16 23:48): NPC Alton's "A Ansprechen" showed 750 ms into the walk to the elevator, stood steady, and the walk stopped short of the door; the talk then opened Alton's line. - Plans, about 3/4 of each measured walk: 02.05 to_lobby_elevator and 03.01 to_2f_elevator 1500 (2 s), 02.06 to_bed and 03.10 to_lab_elevator 750 (1 s). Walks with no measurement keep 0. - Lint: "end_after_ms" without an "end" fails. The walk's args move into walk_args() (make_specs() was over 50 lines).
Three looks come before the walk's first slice, so with three party bars between Alton's prompt and the door's the door's showed at 1750 ms. Four put it at 2000 ms, as the case's name and line say.
Owner
Author
|
Superseded by #644 (one lean branch; split for review later) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #630 (base plza/prompt-steady; the diff shows only this change).
In run 14 (German, console B), 02.05's walk to the elevator stopped 750 ms in on NPC Alton's steady "A Ansprechen" beside the path, short of the door, and the talk opened Alton's line. A walk with "end" now takes an optional "end_after_ms": the end event seen before that much of the last leg is passed on the way. It is set to about 3/4 of each measured walk: 02.05 to_lobby_elevator and 03.01 to_2f_elevator 1500, 02.06 to_bed and 03.10 to_lab_elevator 750; unmeasured prompt walks (01.03, 03.02b, 03.05) keep 0, and 02.04/03.04 end on a turn. Tested by AutoStoryGame run cases (run 14's sequence: a prompt at 750 ms while walking, the elevator's at 2 s) and a lint case; built and run by Fork Draft CI.